Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(eyebrow): adding eyebrow variation #32

Merged
merged 5 commits into from
Dec 11, 2024
Merged

feat(eyebrow): adding eyebrow variation #32

merged 5 commits into from
Dec 11, 2024

Conversation

ObedVega
Copy link
Collaborator

Description

Adding eyebrow variation for AI Unlimited by Edition

What's included?

  • Eyebrow variation for AI Unlimited by Edition

Test Steps

  • npm run start
  • then this
  • finally this

General Tests for Every PR

  • npm run start still works.
  • npm run lint passes.
  • npm test passes and code coverage is not lower.
  • npm run build still works.

image

@ObedVega ObedVega requested a review from bsahitya December 10, 2024 22:17
Copy link
Collaborator

@bsahitya bsahitya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@@ -70,7 +70,7 @@
}

.caption,
.eyebrow {
.eyebrow, .eyebrow2 {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since you added the custom css property .eyebrow2 class is not needed anymore.

@@ -94,6 +95,11 @@
}
}

.eyebrow2 {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same here. .eyebrow2 class is not needed anymore.

@ObedVega ObedVega requested a review from bsahitya December 11, 2024 18:12
@ObedVega ObedVega merged commit 8032ee5 into main Dec 11, 2024
3 checks passed
@owilliams320
Copy link
Collaborator

🎉 This PR is included in version 1.13.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants