-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(eyebrow): adding eyebrow variation #32
Conversation
libs/react-components/src/lib/components/Typography/styles.module.scss
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
@@ -70,7 +70,7 @@ | |||
} | |||
|
|||
.caption, | |||
.eyebrow { | |||
.eyebrow, .eyebrow2 { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since you added the custom css property .eyebrow2
class is not needed anymore.
@@ -94,6 +95,11 @@ | |||
} | |||
} | |||
|
|||
.eyebrow2 { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same here. .eyebrow2
class is not needed anymore.
libs/react-components/src/lib/components/Typography/Typography.stories.tsx
Outdated
Show resolved
Hide resolved
🎉 This PR is included in version 1.13.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Description
Adding eyebrow variation for AI Unlimited by Edition
What's included?
Test Steps
npm run start
General Tests for Every PR
npm run start
still works.npm run lint
passes.npm test
passes and code coverage is not lower.npm run build
still works.