Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG]Applying cpu tweaks is not going to proceed #4

Closed
nabbiriri opened this issue Sep 18, 2022 · 44 comments
Closed

[BUG]Applying cpu tweaks is not going to proceed #4

nabbiriri opened this issue Sep 18, 2022 · 44 comments
Assignees
@Teramanbr
Labels
bug Something isn't working english answer in english good first issue Good for newcomers

Comments

@nabbiriri
Copy link

Thank you for making a good program.

However, as the title says, it does not proceed in the applying cpu tweaks stage.

I tested it in PC, notebook, and one(PC) was fine (but it did not proceed when re-applied), but the other one(notebook) continued to issue problems. Please check the notebook details as below.

Thanks

Desktop (please complete the following information):

  • OS: windows 10 lot enterprise Ltsc
  • OS Version: 21H2
  • CPU/RAM: i5 5200u 2.2ghz/8gb
@nabbiriri nabbiriri added the bug Something isn't working label Sep 18, 2022
@Teramanbr Teramanbr added good first issue Good for newcomers english answer in english labels Sep 18, 2022
@Teramanbr
Copy link
Owner

Hello and thank you for your feedback!
Im sorry to hear you having problems with Terabyte Tweaker, It may have something to do about the core checking feature.
Here is how it works:
Terabyte Tweaker will check if your computer meets a standard for CPU or has HyperThreading turned ON, and if you only have 2 cores and no HyperThreading (Appears to be your case) it will try and skip most of the CPU tweaks and simply add some regedits for CPU improvement.
It may be a problem when creating a backup of your computer's actual Registry, which should be in the folder "C:\TT\TTRevert\ognic.reg" and if there is no such file in there, or the file is empty then the problem is the backup creation.

TLDR: Could you please check if the file "C:\TT\TTRevert\ognic.reg" exists and isn't blank? Thanks in advance. (also, always good to try using the tweaker again after rebooting your computer beforehand)

@nabbiriri
Copy link
Author

nabbiriri commented Sep 19, 2022 via email

@Teramanbr
Copy link
Owner

Hello, just checked here and this file needs access so to see contents.
Please try and make it public, thanks.

@nabbiriri
Copy link
Author

nabbiriri commented Sep 19, 2022 via email

@Teramanbr
Copy link
Owner

By checking the files, it is possible to see that the program indeed hasn't finished his actions.
It seems to be a problem specifically for your computer, are you able to check for the tweaks specifically?
Test for CPU Tweaks.zip
This zip contains a batch file with only the CPU tweaks, could you test if it runs alone? If it doesn't then please tell me so i can divide the code in parts, which you can use to test to which point they run so we can map out where exactly the problem is.
Thanks in advance.

@nabbiriri
Copy link
Author

nabbiriri commented Sep 20, 2022 via email

@Teramanbr
Copy link
Owner

Divided the code in parts, could you tell me if any of these are able to run and if so, which aren't?
Download this Test for Individual Tweaks and tell me, please.

Thanks

@nabbiriri
Copy link
Author

nabbiriri commented Sep 20, 2022 via email

@nabbiriri
Copy link
Author

nabbiriri commented Sep 21, 2022 via email

@Teramanbr
Copy link
Owner

The power plan not being changed appears to be a server issue, i was using the Power Plan directly from Hone's Discord and will from now on start using github as a host.

And since test 1 and 2 are working properly, seems it is not a problem on using wmic to check CPU Cores counting
I will check on this third test as it seems to not work properly on my computer aswell.

@Teramanbr
Copy link
Owner

Teramanbr commented Sep 21, 2022 •
edited
Loading

Found out the reason for Terabyte Tweaker not being able to create the folder "C:\TT\TTRevert\ognic.reg" and also fixed it.
Update is going live as soon as this Thread ends and your problem is resolved.

@Teramanbr
Copy link
Owner

Teramanbr commented Sep 23, 2022 •
edited
Loading

Sorry for taking so long, seems like a problem on the CPU regedits, a part of the code that is easily removed without a big impact on peformance.
I will send here a "beta" version of the program tomorrow so you can test if it works.

@nabbiriri
Copy link
Author

nabbiriri commented Sep 24, 2022 via email

@Teramanbr
Copy link
Owner

Here you go, this is the next update to Terabyte Tweaker and seems to be working correctly with me, but i want you to test it first to make it sure.

All of the updates inside of this file were already commited to github, only thing left is drafting the new release.

@nabbiriri
Copy link
Author

nabbiriri commented Sep 25, 2022 via email

@Teramanbr
Copy link
Owner

Oh my god, im so sorry!
I normally have a shortcut to the tweaker on my desktop and i just copypasted it when i got it working.
Here you go!
Sorry again and thanks for your patience!

@nabbiriri
Copy link
Author

nabbiriri commented Sep 25, 2022 via email

@Teramanbr
Copy link
Owner

Just like before, access denied on google drive.

@nabbiriri
Copy link
Author

nabbiriri commented Sep 25, 2022 via email

@nabbiriri
Copy link
Author

nabbiriri commented Sep 25, 2022 via email

@Teramanbr
Copy link
Owner

This problem seems really hard to fix but i will try my best, apparently, it happens specifically on your computer.
I have also tested this "beta" version on other computer and it seems to work properly, but i will run more tests and will release an major update to the tweaker really soon.

@Teramanbr
Copy link
Owner

Just released a new stable version to Terabyte Tweaker, could you check it out? Here is the Download.
Thanks.

@Teramanbr
Copy link
Owner

Just tested with a friend's notebook and apparently it happens on his too, maybe it is a problem specifically on notebooks.
The only way to got past this point apparently is clicking CTRL+C and then N to cancel the actual procedure and then continue using the rest of the program.
This should be a temporary fix, while i don't find out exactly the problem.

@nabbiriri
Copy link
Author

nabbiriri commented Sep 28, 2022 via email

@andreykolesnikov
Copy link

andreykolesnikov commented Sep 28, 2022 •
edited
Loading

Hey, I have the same issues. And I have ognic.reg file(not empty) in TT folder. PC on Windows 10

@maurye80
Copy link

same here with a Lenovo Laptop ideapad windows 10 And I have ognic.reg file too.

a big thank you anyway for this great program, it works really well apart from this small problem. I am sure you will quickly find the solution. you're a master, respect!

@Teramanbr
Copy link
Owner

Program seems to run fully, apart for the CPU tweaks and seems to be creating a loop specifically on laptops and not in desktops.
At least this is my main suspiction right now, this will be really hard to test, mainly because i don't have a laptop.
Will try my best though.

@Teramanbr
Copy link
Owner

Finding a way to emulate a laptop specifically has proven itself to be an incredibily hard task, i may have to borrow a friend's PC soon just to be able to see what is happening properly.

@Teramanbr
Copy link
Owner

I think i know what we can do, can you remove the first line of code "@echo off" and run the program? This will show specifically what is happening and which lines of code are being run.
If there is a loop then please send the entire loop to me, if there is a specific command where it just stops then send the command alone and I will try and fix it.
It should look like this, it will still work as if nothing was happening but the interface will hurt eyes a little bit:
image

@nabbiriri
Copy link
Author

nabbiriri commented Oct 2, 2022 via email

@Teramanbr
Copy link
Owner

I think you forgot to paste the screenshot.

@nabbiriri
Copy link
Author

nabbiriri commented Oct 3, 2022 via email

@Teramanbr
Copy link
Owner

Teramanbr commented Oct 4, 2022 •
edited
Loading

Here you go, i think this should fix it.
Apparently, the problem is on getting to the next part of the code. I shortened it a little and it should work now.

@nabbiriri
Copy link
Author

nabbiriri commented Oct 4, 2022 via email

Teramanbr added a commit that referenced this issue Oct 7, 2022
@Teramanbr
Another attempt of fixing Issue #4
b78293d
@Teramanbr
Copy link
Owner

Tried again and I think this should work now, after adding some more measures to prevent it from suddenly stopping:
Download

@nabbiriri
Copy link
Author

nabbiriri commented Oct 7, 2022 via email

@Teramanbr
Copy link
Owner

Working on another attempt, will be ready by tomorrow!
Sorry for taking so long to answer, school's got me really busy.

Teramanbr added a commit that referenced this issue Oct 12, 2022
@Teramanbr
Fix GPU Tweaks display bug & Fix attempt issue #4
26ff598
@Teramanbr
Copy link
Owner

Teramanbr commented Oct 12, 2022 •
edited
Loading

And here is another attempt.
Hope it works now, i really don't know what else to change to make it stop happening, and can't seem to find a command for timeoutting other commands after an amount of time.
If this doesn't change soon, i will have to resort to the big guns: PowerShell.

@nabbiriri
Copy link
Author

nabbiriri commented Oct 13, 2022 via email

@Teramanbr
Copy link
Owner

Yeah, i am taking a while to learn how to use PowerShell, will update as soon as I'm able actually understand how to use it.

@Teramanbr
Copy link
Owner

I took a lot of time but think I finally did it.
Please, try out The Latest Release, It should work normally now.

@maurye80
Copy link

Everything seems to be working correctly since your update, the process ended without crashing or blocking! A big thank you and bravo for your determination, respect

@nabbiriri
Copy link
Author

nabbiriri commented Dec 23, 2022 via email

@Teramanbr
Copy link
Owner

Thank you all for waiting, now if you excuse me, I gotta lay down in fetal position for some hours.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Teramanbr Teramanbr

Labels
bug Something isn't working english answer in english good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@andreykolesnikov @Teramanbr @nabbiriri @maurye80