feat: Case-insensitive biome id and renamed property 'displayName' #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this also fixes a missed reference to the Core module
skaldarnar
added
the
Type: Improvement
jdrueckert
approved these changes
May 17, 2020
skaldarnar
added a commit
that referenced
this pull request
May 17, 2020
* feat: Use Name instead String for biome ids * chore: update module version and dependencies * chore: update module.txt Co-authored-by: Niruandaleth <[email protected]>
jdrueckert
added a commit
to Terasology/AnotherWorld
that referenced
this pull request
May 19, 2020
jdrueckert
added a commit
to Terasology/GrowingFlora
that referenced
this pull request
May 19, 2020
jdrueckert
added a commit
to Terasology/Alchemy
that referenced
this pull request
May 19, 2020
jdrueckert
added a commit
to Terasology/Exoplanet
that referenced
this pull request
May 19, 2020
jdrueckert
added a commit
to Terasology/AnotherWorld
that referenced
this pull request
May 19, 2020
jdrueckert
added a commit
to Terasology/Lost
that referenced
this pull request
May 19, 2020
jdrueckert
added a commit
to Terasology-Archived/NeoTTA
that referenced
this pull request
May 19, 2020
jdrueckert
added a commit
to Terasology/PolyWorld
that referenced
this pull request
May 19, 2020
jdrueckert
added a commit
to Terasology/ShatteredPlanes
that referenced
this pull request
May 19, 2020
jdrueckert
added a commit
to Terasology-Archived/WoodAndStone
that referenced
this pull request
May 19, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think the biome ID should be case-insensitive and thus use the
Nameclass instead of a plain string.To clarify the difference between the ID and the display name I renamed the
nameaccordingly.