Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(build): add missing test dependency #17

Merged
merged 3 commits into from
May 25, 2020
Merged

fix(build): add missing test dependency #17

merged 3 commits into from
May 25, 2020

Conversation

keturn
Copy link
Contributor

@keturn keturn commented May 24, 2020 •
edited by pollend
Loading

tests DoDamage, which requires Health

skaldarnar
skaldarnar reviewed May 24, 2020
View reviewed changes
Copy link
Contributor

@skaldarnar skaldarnar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If tests are the only reason for this dependency, it should at most be an optional dependency. However, I'm wondering if the DoDamage is of such existential necessity that it should be added for testing purposes...

module.txt Outdated Show resolved Hide resolved
@keturn @skaldarnar
fix: make test dependency optional
b7298dd 
i.e. compile-time only

Co-authored-by: Tobias Nett <[email protected]>
@skaldarnar skaldarnar merged commit 0294c71 into Terasology:develop May 25, 2020
@skaldarnar skaldarnar mentioned this pull request May 25, 2020
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skaldarnar skaldarnar skaldarnar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@keturn @skaldarnar