BasicCrafting and Genome at GenomeAuthoritySystem

[DarkWeird]

Genome and BasicCrafting modules is optional dependencies for SimpleFarming.
Both modules using at GenomeAuthoritySystem,
then GenomeAuthoritySystem loads(works) when both modules is active.

Suggestions:

1. extract BasicCrafting usage from GenomeAuthoritySystem, if BasicCrafting and Genome can be using separately there.
2. or enrich class with java docs, which explain that this system using both modules together only.

[skaldarnar]

The only event handler integrating with Basic Crafting is onRecipeCraftedEvent, which only works if Genome is also active.

SimpleFarming/src/main/java/org/terasology/simpleFarming/systems/GenomeAuthoritySystem.java

Lines 143 to 164 in b3c691b

	@ReceiveEvent
	public void onRecipeCraftedEvent(OnRecipeCrafted event, EntityRef entity) {
	EntityRef ingredients[] = event.getIngredients();
	if (ingredients.length != 2) {
	return;
	}
	if (!(ingredients[0].hasComponent(GenomeComponent.class) || ingredients[1].hasComponent(GenomeComponent.class))) {
	return;
	}
	SimpleGenomeManager genomeManager = new SimpleGenomeManager();
	boolean result = genomeManager.applyBreeding(ingredients[0], ingredients[1], entity);
	if (entity.hasComponent(GenomeComponent.class)) {
	GenomeMap genomeMap =
	genomeRegistry.getGenomeDefinition(entity.getComponent(GenomeComponent.class).genomeId).getGenomeMap();
	float fillingModifier = genomeMap.getProperty("filling", entity.getComponent(GenomeComponent.class).genes,
	Float.class);
	float newFilling = entity.send(new ModifyFilling(fillingModifier)).filling.getValue();
	entity.send(new ModifyTint(newFilling));
	}
	}

We can split this system into two:

• GenomeExtensionAuthoritySystem (works if at least Genome is loaded)
• GenomeCraftingExtensionAuthoritySystem (works if both Genome and Basic Crafting are loaded)

I haven't looked at the details to figure out whether the genome-only features only make sense if crafting is also enabled, though.