Deepro dev #2
Merged
Deepro dev #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ad12
requested changes
Aug 9, 2022
| @@ -218,7 +218,7 @@ def eval(cfg, args, model, weights_basename, criterion, best_value): | |||
| and angle is None | |||
| and translation is None | |||
| and nshots is None | |||
| and trajectory == "None" | |||
| and trajectory == "none" | |||
There was a problem hiding this comment.
why are all of these fields gated by an if statemnt? are you trying to set default values?
There was a problem hiding this comment.
Yes, just setting default values here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes for motion corruption so that it's properly working within meddlr. Earlier, it turns out motion corruption was just obliterating the image instead of properly motion corrupting it. The specific changes that fixed it are in transform.py - essentially, conversion of image into something that the motion corruption method can handle was missing as well as proper conversion of the image into the kspace using SenseModel and permute. With these fixes, motion corruption does seem to be working properly now.