Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Temporal fix for #364 #378

Merged
merged 3 commits into from
Jun 23, 2024
Merged

Temporal fix for #364 #378

merged 3 commits into from
Jun 23, 2024

Conversation

chemlzh
Copy link
Contributor

@chemlzh chemlzh commented Jun 1, 2024

What is it?

Temporal fix for #364, now backpacks can be dyed, both belt and pack. However, GTM chemical dyes can also be used for recipes, which is not expected. Besides, backpacks cannot be dyed in chemical bath machines. The difficulty to fix these bugs is that I have not figured out how to set dyed color, since it's not replacing but mixing with original color.

Temporal fix for TerraFirmaGreg-Team#364, now backpacks can be dyed, both belt and pack.
However, GTM chemical dyes can be used for recipes, which is not expected. Besides, backpacks cannot be dyed with chemical bath machines.
The difficulty to fix these bugs is that I have not figured out how to set dyed color, since it's not replacing but mixing with original color.
@chemlzh chemlzh marked this pull request as ready for review June 1, 2024 07:48
@chemlzh
Copy link
Contributor Author

chemlzh commented Jun 1, 2024

@Xikaro @FriendlyCube Do you have any idea for this (temporal) backpack dyeing fix?

@Exzept1on
Copy link
Contributor

I'll think about this fix myself later, I'm a little busy right now

@Xikaro Xikaro merged commit bf2e958 into TerraFirmaGreg-Team:main Jun 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants