Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allows all colors of glass to be macerated/hammered to dust #713

Merged

Conversation

CaptainGold1
Copy link
Contributor

What is the new behavior?

All colors of glass (and tinted glass as well) can now be macerated in the macerator or hammered in the crafting window to dust. Colored glass panes work as well.

Implementation Details

The default maceration recipes for glass and glass panes were removed and replaced with #forge:glass and #forge:glass_panes.

Outcome

Most TFC sands by default output colored glass, while previously only clear glass could provide glass dust (needed for vacuum tubes). This means you had to go out searching for white sand for silica batches to progress into LV. Allowing colored glasses allows all sand types to be used for glass dust.

Additional Information

The Create bamboo and cherry glass panes are tagged with #forge:glass_panes, so show up in the list of possible inputs for tiny glass dust. However, these items are hidden from EMI and have no recipes, so they're not intended inputs. A possible fix is to remove #forge:glass_panes from these blocks?

@Pyritie
Copy link
Contributor

Pyritie commented Jan 13, 2025

The Create bamboo and cherry glass panes are tagged with #forge:glass_panes, so show up in the list of possible inputs for tiny glass dust. However, these items are hidden from EMI and have no recipes, so they're not intended inputs. A possible fix is to remove #forge:glass_panes from these blocks?

If they aren't craftable, does adding c:hidden_from_recipe_viewers to those items work?

@CaptainGold1
Copy link
Contributor Author

Probably, I can go ahead and test that in a couple hours.

@CaptainGold1
Copy link
Contributor Author

Okay, I committed a change that seems to work. It seems that those specific glass panes were added by create_connected and thus aren't in the create blacklist. I mirrored the implementation that blacklists create items into a new js file, hopefully it's the proper way to do it but point out if it isn't. The glass panes no longer show up as valid inputs.

@Xikaro Xikaro added this to the 0.7.17 milestone Jan 14, 2025
@Xikaro Xikaro added the 1. Type: Feature New feature or request. label Jan 14, 2025
@Exzept1on Exzept1on merged commit 7f69d76 into TerraFirmaGreg-Team:main Jan 17, 2025
@CaptainGold1 CaptainGold1 deleted the colored_glass_macerate branch January 18, 2025 05:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1. Type: Feature New feature or request.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants