Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added budding crystals for the other gemstone ores #731

Merged
merged 23 commits into from
Jan 25, 2025

Conversation

Pyritie
Copy link
Contributor

@Pyritie Pyritie commented Jan 19, 2025

What is the new behavior?

If the ore has a gem associated with it, its new indicator is that gem.
image
image
image
image
image

Implementation Details

Ore indicators were all adjusted to use these new assets.
I added shimmer entries to them all, so they all glow. If it's too much, I can disable this lol.
Also I updated the field guide for any new indicators.

Outcome

Better looking indicators

Additional Information

The new indicators are visible on the minimap. I don't know if that's a problem. They can also be pretty bright at night.

Also I buffed the deep_sapphire vein because it was also very rare, and updated the field guide to match.

@Xikaro Xikaro added the 1. Type: Feature New feature or request. label Jan 19, 2025
@Xikaro Xikaro modified the milestones: 0.7.17, 0.7.18 Jan 19, 2025
@Pyritie
Copy link
Contributor Author

Pyritie commented Jan 19, 2025

I tweaked the textures a bit, so they're less bright.

image
image

@Pyritie
Copy link
Contributor Author

Pyritie commented Jan 19, 2025

by the way, I tried adding this mod to my game, it works just fine and and it doesn't need any changes so I can't make a PR for it:

https://www.curseforge.com/minecraft/mc-mods/tfc-ruined-world

image
image

like imagine being new to the game and stumbling across that castle! that'd be a sick starter base!

they have no loot or anything, they're just decoration

@SverhRazum-Nah
Copy link
Contributor

Are indicators of all ores and gems really necessary?
I thought indicators were needed for the early stage of the game, when it is difficult to find ore in any other way, and therefore they are available for the necessary ores. But then, a scanner appears, and the indicators are no longer necessary. In addition, these ores are not needed at the beginning of the game anyway, and when they are needed, most likely the scanner will already be ready. 🤔

@Pyritie
Copy link
Contributor Author

Pyritie commented Jan 19, 2025

Are indicators of all ores and gems really necessary? I thought indicators were needed for the early stage of the game, when it is difficult to find ore in any other way, and therefore they are available for the necessary ores. But then, a scanner appears, and the indicators are no longer necessary. In addition, these ores are not needed at the beginning of the game anyway, and when they are needed, most likely the scanner will already be ready. 🤔

no, but I think they look kinda cool

@Exzept1on Exzept1on merged commit 7543a23 into TerraFirmaGreg-Team:main Jan 25, 2025
@Pyritie Pyritie deleted the crystals branch January 25, 2025 16:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1. Type: Feature New feature or request.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants