-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added budding crystals for the other gemstone ores #731
Conversation
Signed-off-by: Pyritie <[email protected]>
Signed-off-by: Pyritie <[email protected]>
Signed-off-by: Pyritie <[email protected]>
Signed-off-by: Pyritie <[email protected]>
Signed-off-by: Pyritie <[email protected]>
Signed-off-by: Pyritie <[email protected]>
Signed-off-by: Pyritie <[email protected]>
Signed-off-by: Pyritie <[email protected]>
Signed-off-by: Pyritie <[email protected]>
Signed-off-by: Pyritie <[email protected]>
Signed-off-by: Pyritie <[email protected]>
Signed-off-by: Pyritie <[email protected]>
Signed-off-by: Pyritie <[email protected]>
Signed-off-by: Pyritie <[email protected]>
Signed-off-by: Pyritie <[email protected]>
Signed-off-by: Pyritie <[email protected]>
Signed-off-by: Pyritie <[email protected]>
Signed-off-by: Pyritie <[email protected]>
Signed-off-by: Pyritie <[email protected]>
by the way, I tried adding this mod to my game, it works just fine and and it doesn't need any changes so I can't make a PR for it: https://www.curseforge.com/minecraft/mc-mods/tfc-ruined-world like imagine being new to the game and stumbling across that castle! that'd be a sick starter base! they have no loot or anything, they're just decoration |
Are indicators of all ores and gems really necessary? |
no, but I think they look kinda cool |
Signed-off-by: Pyritie <[email protected]>
Signed-off-by: Pyritie <[email protected]>
Signed-off-by: Pyritie <[email protected]>
What is the new behavior?
If the ore has a gem associated with it, its new indicator is that gem.





Implementation Details
Ore indicators were all adjusted to use these new assets.
I added shimmer entries to them all, so they all glow. If it's too much, I can disable this lol.
Also I updated the field guide for any new indicators.
Outcome
Better looking indicators
Additional Information
The new indicators are visible on the minimap. I don't know if that's a problem. They can also be pretty bright at night.
Also I buffed the
deep_sapphire
vein because it was also very rare, and updated the field guide to match.