Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds heat values for items with valid heating recipes but no heat values #753

Merged
merged 3 commits into from
Jan 25, 2025

Conversation

CaptainGold1
Copy link
Contributor

What is the new behavior?

Fixes the issue where crushed/processed ores do not heat up and thus can never melt into anything in the crucible/blast furnace. Also removed the page in the blast furnace tips that detailed which inputs would work, since all inputs should now work so the page is now irrelevant.

Implementation Details

Added item heat values through makeItemHeatByTagPrefix() in tfc/data.js for the various stages of ore processing. This should not have any adverse affects, as far as I can tell, as it should only affect ores.

Outcome

Now you can melt your purified ores directly into liquid, if you so desire. Although it is incredibly stupid to do so, but to each their own.

Additional Information

image

This entry is now unnecessary as all inputs should work in the blast furnace.
@CaptainGold1
Copy link
Contributor Author

Oh wait, blocks don't melt down either, going to add the heat values for those real quick

@CaptainGold1 CaptainGold1 changed the title Processed ores heat Adds heat values for items with valid heating recipes but no heat values Jan 24, 2025
@CaptainGold1
Copy link
Contributor Author

Okay, now blocks and long rods have heat values too, so they can be melted down as well. I might look into there possibly being some way to overhaul the way heating recipes are currently generated?

@CaptainGold1
Copy link
Contributor Author

Side note, is there any chance that the source code for TFG-Core will be released any time soon? Doing an overhaul of how item heats work so that different metals have different heat capacities would be fairly easy if I could edit TFG-Core to include heat capacities for every metal.

@Xikaro Xikaro added the 1. Type: Feature New feature or request. label Jan 25, 2025
@Xikaro Xikaro added this to the 0.7.19 milestone Jan 25, 2025
@Exzept1on
Copy link
Contributor

I want us to move away from using TFG-Core in a lot of things related to the modpack, as it was done in 0.8.2, almost everything is done there based on KJS, if someone wants to port the code or write it again, why not.

@Exzept1on Exzept1on merged commit ab9a22d into TerraFirmaGreg-Team:main Jan 25, 2025
@CaptainGold1 CaptainGold1 deleted the processed-ores-heat branch January 25, 2025 20:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1. Type: Feature New feature or request.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants