Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add cancel button to 'Do you want to save?' message box #1185

Merged
merged 1 commit into from
Feb 14, 2025
Merged

Conversation

rowo360
Copy link
Contributor

@rowo360 rowo360 commented Feb 12, 2025

This PR fixes #1183 by adding a cancel button to the 'Do you want to save?' message box.

Overall the MessageBox looks like this now:

From a technial point of view I introduced a new enum MessageBoxResult representing the return values of a MessageBox.
This enum is intended to pursue the idea of the IMessageBox interface further: hiding the implementation details of the Windows Forms MessageBox to the caller.
So far a boolean return value was sufficient for all methods of the IMessageBox interface - however the new method YesNoCancel requires more than a boolean state - do I decided to use that enum.

@rowo360 rowo360 self-assigned this Feb 12, 2025
@rowo360 rowo360 merged commit f04915e into main Feb 14, 2025
2 checks passed
@rowo360 rowo360 deleted the issue-1183 branch February 14, 2025 06:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Save test project before closing: add 'cancel' option to MessageBox
1 participant