Enable GetDirectoryName

Testably · Apr 17, 2024 · 9281a1c · 9281a1c
1 parent 75396c7
commit 9281a1c
Show file tree

Hide file tree

Showing 4 changed files with 73 additions and 1 deletion.
diff --git a/Source/Testably.Abstractions.Testing/Helpers/Execute.LinuxPath.cs b/Source/Testably.Abstractions.Testing/Helpers/Execute.LinuxPath.cs
@@ -43,10 +43,24 @@ public override string GetTempPath()
 		public override bool IsPathRooted(string? path)
 			=> path?.Length > 0 && path[0] == '/';
 
+		/// <summary>
+		///     https://github.com/dotnet/runtime/blob/v8.0.4/src/libraries/Common/src/System/IO/PathInternal.Unix.cs#L22
+		/// </summary>
+		protected override int GetRootLength(string path)
+		{
+			return path.Length > 0 && IsDirectorySeparator(path[0]) ? 1 : 0;
+		}
+
 		/// <summary>
 		///     https://github.com/dotnet/runtime/blob/v8.0.4/src/libraries/Common/src/System/IO/PathInternal.Unix.cs#L27
 		/// </summary>
 		protected override bool IsDirectorySeparator(char c)
 			=> c == DirectorySeparatorChar;
+
+		/// <summary>
+		///     https://github.com/dotnet/runtime/blob/v8.0.4/src/libraries/Common/src/System/IO/PathInternal.Unix.cs#L89
+		/// </summary>
+		protected override bool IsEffectivelyEmpty(string path)
+			=> string.IsNullOrEmpty(path);
 	}
 }
diff --git a/Source/Testably.Abstractions.Testing/Helpers/Execute.SimulatedPath.cs b/Source/Testably.Abstractions.Testing/Helpers/Execute.SimulatedPath.cs
@@ -159,7 +159,28 @@ public ReadOnlySpan<char> GetDirectoryName(ReadOnlySpan<char> path)
 
 		/// <inheritdoc cref="IPath.GetDirectoryName(string)" />
 		public string? GetDirectoryName(string? path)
-			=> System.IO.Path.GetDirectoryName(path);
+		{
+			if (path == null || IsEffectivelyEmpty(path))
+			{
+				return null;
+			}
+
+			int rootLength = GetRootLength(path);
+			for (int i = path.Length - 1; i >= 0; i--)
+			{
+				char ch = path[i];
+
+				if (IsDirectorySeparator(ch))
+				{
+					if (i > rootLength)
+					{
+						return path.Substring(0, i);
+					}
+				}
+			}
+
+			return "";
+		}
 
 #if FEATURE_SPAN
 		/// <inheritdoc cref="IPath.GetExtension(ReadOnlySpan{char})" />
@@ -450,7 +471,9 @@ public bool TryJoin(ReadOnlySpan<char> path1,
 		private static string CombineInternal(string[] paths)
 			=> System.IO.Path.Combine(paths);
 
+		protected abstract int GetRootLength(string path);
 		protected abstract bool IsDirectorySeparator(char c);
+		protected abstract bool IsEffectivelyEmpty(string path);
 
 #if FEATURE_PATH_ADVANCED
 		private static string JoinInternal(string?[] paths)

diff --git a/Source/Testably.Abstractions.Testing/Helpers/Execute.WindowsPath.cs b/Source/Testably.Abstractions.Testing/Helpers/Execute.WindowsPath.cs
@@ -1,4 +1,5 @@
 using System;
+using System.Linq;
 
 namespace Testably.Abstractions.Testing.Helpers;
 
@@ -63,12 +64,45 @@ public override bool IsPathRooted(string? path)
 			       (length >= 2 && IsValidDriveChar(path![0]) && path[1] == VolumeSeparatorChar);
 		}
 
+		/// <summary>
+		///     https://github.com/dotnet/runtime/blob/v8.0.3/src/libraries/Common/src/System/IO/PathInternal.Windows.cs#L181
+		/// </summary>
+		protected override int GetRootLength(string path)
+		{
+			if (path.Length >= 2
+			    && path[1] == ':'
+			    && IsValidDriveChar(path[0]))
+			{
+				if (path.Length > 2 && IsDirectorySeparator(path[2]))
+				{
+					return 3;
+				}
+
+				return 2;
+			}
+
+			return 0;
+		}
+
 		/// <summary>
 		///     https://github.com/dotnet/runtime/blob/v8.0.4/src/libraries/Common/src/System/IO/PathInternal.Windows.cs#L280
 		/// </summary>
 		protected override bool IsDirectorySeparator(char c)
 			=> c == DirectorySeparatorChar || c == AltDirectorySeparatorChar;
 
+		/// <summary>
+		///     https://github.com/dotnet/runtime/blob/v8.0.4/src/libraries/Common/src/System/IO/PathInternal.Windows.cs#L381
+		/// </summary>
+		protected override bool IsEffectivelyEmpty(string path)
+		{
+			if (string.IsNullOrEmpty(path))
+			{
+				return true;
+			}
+
+			return path.All(c => c == ' ');
+		}
+
 		/// <summary>
 		///     Returns true if the given character is a valid drive letter
 		/// </summary>

diff --git a/...s/Testably.Abstractions.Tests.SourceGenerator/ClassGenerators/FileSystemClassGenerator.cs b/...s/Testably.Abstractions.Tests.SourceGenerator/ClassGenerators/FileSystemClassGenerator.cs
@@ -233,6 +233,7 @@ private bool IncludeSimulatedTests(ClassModel @class)
 		[
 			"ChangeExtensionTests",
 			"EndsInDirectorySeparatorTests",
+			"GetDirectoryNameTests",
 			"GetExtensionTests",
 			"GetPathRootTests",
 			"GetRandomFileNameTests",