ASCATransactionQueue interface trashing improvements #1216
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adlai-Holler
approved these changes
Nov 6, 2018
|
Diff looks good, but can you give a description on how this improves interface trashing? |
maicki
changed the title
maicki
force-pushed
the
MSDeallocQueueImprovements
branch
from
551dca3 to
1865cbd
Compare
wiseoldduck
reviewed
Nov 6, 2018
maicki
force-pushed
the
MSDeallocQueueImprovements
branch
from
1865cbd to
6ae7fcb
Compare
appleguy
reviewed
Nov 8, 2018
| @@ -377,17 +372,13 @@ - (instancetype)init | |||
| // __unsafe_unretained allows us to avoid flagging the memory cycle detector. | |||
| __unsafe_unretained __typeof__(self) weakSelf = self; | |||
| void (^handlerBlock) (CFRunLoopObserverRef observer, CFRunLoopActivity activity) = ^(CFRunLoopObserverRef observer, CFRunLoopActivity activity) { | |||
| while (weakSelf->_internalQueue.count > 0) { | |||
There was a problem hiding this comment.
Indentation seems wrong here?
|
Say before the change we are processing nodes 1, 2, 3 in queue, but the process of node 1 may do something that changes node 3's state. The while loop will handle that case, otherwise node 3's change by node 1 will be pushed to next loop. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.