support dynamic images in iOS13 #1630
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
vovasty
force-pushed
the
dynamic-images
branch
2 times, most recently
from
186f52e to
868448c
Compare
|
@vovasty Please rebase with latest master to get the right CI configs. Thanks. |
vovasty
force-pushed
the
dynamic-images
branch
4 times, most recently
from
12db9df to
c12c04c
Compare
CLA signed
vovasty
force-pushed
the
dynamic-images
branch
from
c12c04c to
8487312
Compare
rahul-malik
approved these changes
Aug 23, 2019
matthewd1234
pushed a commit
to matthewd1234/Texture
that referenced
this pull request
Aug 25, 2019
…eGroup#1630) Currently ASImageNode would initially load the correct asset from the asset catalog but would not respond to changes in trait collections that would require loading a different asset from the asset catalog. This change allows use to use `-[UIImage imageAsset]` to reference the asset catalog entry for the current image and load the appropriate version based on the current trait collection
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
iOS13 introduced image variants for dark and light modes. This change provides support for such kind of images.
NB
shall we have a separate cache for dark/light images?