Run Danger with GitHub Actions #1635
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nguyenhuy
force-pushed
the
HN-Danger-Action
branch
7 times, most recently
from
5f0ce51 to
60c4d0c
Compare
jparise
approved these changes
Aug 22, 2019
nguyenhuy
force-pushed
the
HN-Danger-Action
branch
from
ef6398e to
d87aa79
Compare
nguyenhuy
changed the title
nguyenhuy
changed the title
nguyenhuy
force-pushed
the
HN-Danger-Action
branch
from
fb773b4 to
786caad
Compare
nguyenhuy
changed the title
nguyenhuy
force-pushed
the
HN-Danger-Action
branch
from
b20118e to
766c0c2
Compare
garrettmoon
approved these changes
Aug 22, 2019
|
All green! 🎉 Thanks for reviewing! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our Danger check no longer works after we remove the BuiltKite hook. This PR attempts to run Danger with GitHub Actions.
There are 2 projects: Danger Ruby, which is what we've been using, and Danger JS. Both support GitHub Actions but the Danger Ruby action is not yet stable and would fail at build step (danger/danger#1148). As a result, I converted our (Ruby) Dangerfile to a new dangerfile.js file and use it with Danger JS.
There are a couple of issues with the Danger JS setup which are documented in the workflow file (here). Those are not blocking issues IMO.
Test Plan: Tested locally (
yarn danger pr) with multiple PRs: 788, 832, 1492, 1633, 1635, 1528, 1572 and this PR.