Update GraphicsRenderer experiment to support image-formation cancellation #1696
Conversation
|
I guess we need to add |
|
The function already has that argument @vovasty . I'd appreciate some reviews on this, since it's experiment-gated and has shown to impact performance in practice. |
|
@Adlai-Holler I meant |
| // last moment i.e. before actually creating the resulting image. | ||
| __block UIImage *image; | ||
| NSError *error; | ||
| [[[UIGraphicsImageRenderer alloc] initWithSize:size format:format] |
There was a problem hiding this comment.
ASGraphicsCreateImageWithOptions may return nil in case of error or cancelation. It should be reflected in header.
Yes; traitCollection was added for dark mode support. |
|
@Adlai-Holler could you please rebase latest changes from master (it fixes CI) and update nullability? |
…tImage" level as well as during the drawing process.
Adlai-Holler
force-pushed
the
AHGraphicsRendererCancel
branch
from
20775a1 to
44a1df8
Compare
There was a problem hiding this comment.
Hi @Adlai-Holler, thank you for the PR.
could you please
- Update header file with nullability
- add
isCancelledparameter toASGraphicsCreateImageWithTraitCollectionAndOptions - change all places where
ASGraphicsCreateImageWithTraitCollectionAndOptionsis used withoutisCancelledparameter
There was a problem hiding this comment.
LGTM. Let's merge this and follow up with updating the header/documentation with the returned value when error or cancellation occurs (nil). Thanks, @Adlai-Holler!
|
Closing due to #1814 |
This approach is exactly how the convenience function
imageWithActions:is implemented, except that it supports cancellation just like our UIGraphicsBeginImage path.