[ASDisplayNode] Allow explicit setting of accessibilityElements #1807
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since `NSObject` conforms to the informal accessibility protocol, `ASDisplayNode` has an inherited property for `accessibilityElements`. However, setting this property has no effect since `ASDisplayNode` overrides the `accessibilityElements` getter. Added a small change to the getter to check if the `accessibilityElements` property on `ASDisplayNode` has been explicitly set, and if so return that. I also added a comment around `_ASDisplayView`’s `setAccessibilityElements:` method to clear up some (of my own) confusion.
vovasty
reviewed
Apr 22, 2020
vovasty
approved these changes
Apr 22, 2020
nguyenhuy
approved these changes
Apr 22, 2020
|
Our CI pipeline has been a bit flaky lately. |
piotrdebosz
pushed a commit
to getstoryteller/Texture
that referenced
this pull request
Mar 1, 2021
…ureGroup#1807) * [ASDisplayNode] Allow explicit setting of accessibilityElements Since `NSObject` conforms to the informal accessibility protocol, `ASDisplayNode` has an inherited property for `accessibilityElements`. However, setting this property has no effect since `ASDisplayNode` overrides the `accessibilityElements` getter. Added a small change to the getter to check if the `accessibilityElements` property on `ASDisplayNode` has been explicitly set, and if so return that. I also added a comment around `_ASDisplayView`’s `setAccessibilityElements:` method to clear up some (of my own) confusion. * comment tweak * Fix flakey test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since
NSObjectconforms to the informal accessibility protocol,ASDisplayNodehas an inherited property foraccessibilityElements. However, setting this property has no effect sinceASDisplayNodeoverrides theaccessibilityElementsgetter. Added a small change to the getter to check if theaccessibilityElementsproperty onASDisplayNodehas been explicitly set, and if so return that.I also added a comment around
_ASDisplayView’ssetAccessibilityElements:method to clear up some (of my own) confusion.