Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use ASReplaceMethodWithBlock instead of swizzling with a library #1832

Merged
merged 1 commit into from
May 22, 2020
Merged

Use ASReplaceMethodWithBlock instead of swizzling with a library #1832

merged 1 commit into from
May 22, 2020

Conversation

bolsinga
Copy link
Contributor

  • I tried to make these tests work with OCMock, but that only ever saw 1 call.
  • All these do is count -reloadData calls. I'm not sure why so many other methods were recorded.
  • Why we are doing this is the external library targets iOS 5 and is flagged as a warning in builds.

Use ASReplaceMethodWithBlock instead of swizzling with a library
59e33f0 
- I tried to make these tests work with OCMock, but that only ever saw 1 call.
- All these do is count `-reloadData` calls. I'm not sure why so many other methods are recorded.
- Why we are doing this is the library targets iOS 5 and is flagged as a warning in builds.
jparise
jparise reviewed May 22, 2020
View reviewed changes
Copy link
Member

@jparise jparise left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just to confirm, you weren't successful in using OCMock to observer and count the number of expected -reloadData calls?

@bolsinga
Copy link
Contributor Author

bolsinga commented May 22, 2020 •
edited
Loading

Just to confirm, you weren't successful in using OCMock to observer and count the number of expected -reloadData calls?

Yes; I tried most of the morning! I stubbed with counts, used the new times stuff, and sat in the debugger. I was unable to get that to work. This change was the smallest fix in the end to remove the out of date dependency,

@bolsinga bolsinga merged commit 0d7f705 into TextureGroup:master May 22, 2020
@bolsinga bolsinga deleted the SwizzleOurselves branch May 22, 2020 21:58
rcancro pushed a commit to rcancro/Texture that referenced this pull request May 28, 2020
@rcancro
Use ASReplaceMethodWithBlock instead of swizzling with a library (Tex…
a378cb2 
…tureGroup#1832)

- I tried to make these tests work with OCMock, but that only ever saw 1 call.
- All these do is count `-reloadData` calls. I'm not sure why so many other methods are recorded.
- Why we are doing this is the library targets iOS 5 and is flagged as a warning in builds.
piotrdebosz pushed a commit to getstoryteller/Texture that referenced this pull request Mar 1, 2021
@piotrdebosz
Use ASReplaceMethodWithBlock instead of swizzling with a library (Tex…
8d4d6b3 
…tureGroup#1832)

- I tried to make these tests work with OCMock, but that only ever saw 1 call.
- All these do is count `-reloadData` calls. I'm not sure why so many other methods are recorded.
- Why we are doing this is the library targets iOS 5 and is flagged as a warning in builds.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jparise jparise jparise approved these changes

@garrettmoon garrettmoon Awaiting requested review from garrettmoon

@nguyenhuy nguyenhuy Awaiting requested review from nguyenhuy

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bolsinga @jparise