[ASDKgram Example] fix crash on startup

[hannahmbanana]

No description provided.

[maicki]

Thanks Hannah ❤️

[hannahmbanana]

Actually, hold off on merging this. I'm missing a file.

[hannahmbanana]

ready to merge

[ghost]

1 Warning

⚠️

Please ensure license is correct for PhotoFeedBaseController.m: // // PhotoFeedBaseController.m // Texture // // Copyright (c) 2014-present, Facebook, Inc. All rights reserved. // This source code is licensed under the BSD-style license found in the // LICENSE file in the /ASDK-Licenses directory of this source tree. An additional // grant of patent rights can be found in the PATENTS file in the same directory. // // Modifications to this file made after 4/13/2017 are: Copyright (c) 2017-present, // Pinterest, Inc. Licensed under the Apache License, Version 2.0 (the "License"); // you may not use this file except in compliance with the License. // You may obtain a copy of the License at // // http://www.apache.org/licenses/LICENSE-2.0 //

Generated by 🚫 Danger

[nguyenhuy]

I would personally shy away from calling reloadData in a sample project, as we've been asking people to avoid using it and call insert/delete/move instead. Maybe it's time to employ a diffing algorithm (either built-in or from 3rd-party) to show how it's supposed to be done? A bit overkill I know, as the data almost certainly has new rows only.

[appleguy]

@nguyenhuy Yes, I agree. A couple thoughts though:

• We do have the IGListKit version of ASDKgram in place; we could consider making it the only implementation, although I'm not sure how easy it is for a new developer to get set up using it with ASCollectionNode, because we don't have docs about it.

• This fix addresses a pretty serious crash that has been in place for a while. I asked Hannah offline and she is planning to make other changes to ensure only edit operations are used, but the network / loading code needs a small overhaul to be able to do it.

Fortunately the reloadData only occurs during a full reload (e.g. pull to refresh or first load), so it doesn't affect the loading of new batches / pages while scrolling down.

[nguyenhuy]

Sounds good 👌