#[UIC-2110]:updated sliceoptions in slice formdata #244
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ting sliceoptions from subscriberlayer while importing dashboard not saved sliceoptions in subscriberlayer and removed existing sliceoptions from subscriberlayer while importing dashboard sliceoptions will be fetch on runtime UIC-2110
superset/assets/src/explore/components/controls/SubscriberLayer.jsx
Outdated
Show resolved
Hide resolved
did review changes UIC-2110
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CATEGORY
This issue will occur if someone tried to add any slice as subscription layer in chart and that slice have large form_data ( here it is because of unwanted info in* subscriber_layer 's sliceOptions* property) and
While saving slice after updating subscriber layer , REST API (https://rafa001-mgt-01.lab.guavus.com:8443/gateway/rafsso/rvf/dashboardasync/api/read?_flt_0_owners=2)
is called with request headers with more than allowed max HTTP header values (8k) .
Different servers have set default max limit as follows
Apache/Jetty/Nginx/gunicorn - 8K
Tomcat - 8k-48K
Ref links:--
https://www.tutorialspoint.com/What-is-the-maximum-size-of-HTTP-header-values
https://knox.apache.org/books/knox-0-14-0/user-guide.html#Gateway+Server+Configuration
so to fix this issue we have following options
Increase Max limit in Server configuration : At this setup superset is proxied by KNOX server and for KNOX server Request Header values max limit is 8K, so to increase this limit go to Ambari UI and add below property value in Knox Custom gateway-site Tab(updated over setup)
_gateway.httpserver.requestHeaderBuffer = 10240 _
Check/update/remove unwanted info before Importing dashboard .
Not save slice list in form_data of slice and fetch list on runtime while creating subscription layer as per owner.
,so in this PR implementing 2nd and 3rd approach to fix this issue.
Choose one
SUMMARY
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TEST PLAN
ADDITIONAL INFORMATION
REVIEWERS