Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#[RAFD-2169]:redefined row_limit value to max number #245

Merged
merged 1 commit into from
Sep 23, 2019
Merged

#[RAFD-2169]:redefined row_limit value to max number #245

merged 1 commit into from
Sep 23, 2019

Conversation

jitendra-kumawat
Copy link

@jitendra-kumawat jitendra-kumawat commented Sep 19, 2019 •
edited
Loading

CATEGORY

Redefined row_limit value to max number ,so that chart rendered on all datasets

Choose one

  • Bug Fix
  • Enhancement (new features, refinement)
  • Refactor
  • Add tests
  • Build / Development Environment
  • Documentation

SUMMARY

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TEST PLAN

ADDITIONAL INFORMATION

  • Has associated issue:
  • Changes UI
  • Requires DB Migration.
  • Confirm DB Migration upgrade and downgrade tested.
  • Introduces new feature or API
  • Removes existing feature or API

REVIEWERS

@jitendra-kumawat
fix(schema):redefined row limit value to max
061f49d 
redefined row limit value to max

RAFD-2169
bipinsoniguavus
bipinsoniguavus approved these changes Sep 23, 2019
View reviewed changes
Copy link

@bipinsoniguavus bipinsoniguavus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

ankursinghal2005
ankursinghal2005 approved these changes Sep 23, 2019
View reviewed changes
Copy link

@ankursinghal2005 ankursinghal2005 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ankursinghal2005 ankursinghal2005 merged commit 3b2fed6 into master Sep 23, 2019
@ankursinghal2005 ankursinghal2005 deleted the fix/RAFD-2169-increaserowlimit branch September 23, 2019 11:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ankursinghal2005 ankursinghal2005 ankursinghal2005 approved these changes

@bipinsoniguavus bipinsoniguavus bipinsoniguavus approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jitendra-kumawat @ankursinghal2005 @bipinsoniguavus