Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#[UIC-2127]:added point chart support with annotation line #254

Merged
merged 3 commits into from
Oct 13, 2019

Conversation

jitendra-kumawat
Copy link

@jitendra-kumawat jitendra-kumawat commented Oct 10, 2019

CATEGORY

Added point chart support with annotation line

Choose one

  • Bug Fix
  • Enhancement (new features, refinement)
  • Refactor
  • Add tests
  • Build / Development Environment
  • Documentation

SUMMARY

Point chart is kind of scatter plot chart in which Y Axis is category Axis and X-axis is Numeric Axis. In addition to point we are annotating a single vertical line on X-Axis at value =1

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

X_ratio_SP

Screenshot 2019-10-11 at 4 44 53 PM

TEST PLAN

ADDITIONAL INFORMATION

  • Has associated issue:
  • Changes UI
  • Requires DB Migration.
  • Confirm DB Migration upgrade and downgrade tested.
  • Introduces new feature or API
  • Removes existing feature or API

REVIEWERS

added point chart support

UIC-2127
@arpit-agarwal
Copy link

Great work @jitendra-kumawat. Quick turnaround. It seems you made basic properties configurable as well.

make annotation props configurable

UIC-2127
make annotation props configurable

UIC-2127
Copy link

@arpit-agarwal arpit-agarwal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@arpit-agarwal arpit-agarwal merged commit c05436a into master Oct 13, 2019
@arpit-agarwal arpit-agarwal deleted the feature/UIC-2127-pointchart branch October 13, 2019 18:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants