Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#[UIC-2147]: set no filter as default in time selection #259

Merged
merged 1 commit into from
Oct 31, 2019
Merged

#[UIC-2147]: set no filter as default in time selection #259

merged 1 commit into from
Oct 31, 2019

Conversation

rasmi-ranjan-guavus
Copy link

@rasmi-ranjan-guavus rasmi-ranjan-guavus commented Oct 25, 2019 •
edited
Loading

UIC-2147

CATEGORY

Choose one

  • Bug Fix
  • Enhancement (new features, refinement)
  • Refactor
  • Add tests
  • Build / Development Environment
  • Documentation

SUMMARY

Set "no filter" as default in time selection

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TEST PLAN

ADDITIONAL INFORMATION

  • Has associated issue:
  • Changes UI
  • Requires DB Migration.
  • Confirm DB Migration upgrade and downgrade tested.
  • Introduces new feature or API
  • Removes existing feature or API

REVIEWERS

arpit-agarwal
arpit-agarwal approved these changes Oct 25, 2019
View reviewed changes
Copy link

@arpit-agarwal arpit-agarwal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bipinsoniguavus bipinsoniguavus merged commit 198e00b into master Oct 31, 2019
@bipinsoniguavus bipinsoniguavus deleted the feature/UIC-2147-default-no-filter branch October 31, 2019 07:01
bipinsoniguavus pushed a commit that referenced this pull request Oct 31, 2019
@rasmi-ranjan-guavus @bipinsoniguavus
feat(filter-box): set no filter as default in time selection (#259)
89a3a41 
UIC-2147

(cherry picked from commit 198e00b)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arpit-agarwal arpit-agarwal arpit-agarwal approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rasmi-ranjan-guavus @arpit-agarwal @bipinsoniguavus