Fix: [MIQ-2130] Fix big chart by adding LIMIT to control panel #265
Conversation
> Previously limit 50000 was automatically added to the query > Now the automatic addition of limit in the query is not allowed
superset/viz.py
Outdated
| @@ -1097,6 +1097,7 @@ def query_obj(self): | |||
| raise Exception(_('Pick a metric!')) | |||
| d['metrics'] = [self.form_data.get('metric')] | |||
| self.form_data['metric'] = metric | |||
| d['row_limit'] = None | |||
There was a problem hiding this comment.
Rather than hardcoding that we dont set row_limit we will expose this to user.
https://github.com/Guavus/incubator-superset/blob/fix/MIQ-2130-fix-big-chart-query/superset/assets/src/explore/visTypes.jsx#L1407
https://github.com/Guavus/incubator-superset/blob/fix/MIQ-2130-fix-big-chart-query/superset/assets/src/explore/visTypes.jsx#L1435
we will add a control ['row_limit']
Add a None or -1 here https://github.com/Guavus/incubator-superset/blob/fix/MIQ-2130-fix-big-chart-query/superset/assets/src/explore/controls.jsx#L98
Override row_limit choices or dafult can be achieved by
https://github.com/Guavus/incubator-superset/blob/fix/MIQ-2130-fix-big-chart-query/superset/assets/src/explore/visTypes.jsx#L289-L298
This should get you going. In case you still need further assistance let me know
There was a problem hiding this comment.
Thanks for the references, it helped a lot.
On selection of "-1", LIMIT is removed from the query. I dropped the idea of "None" as the options are getting validated if they are an integer or not; hence raises an error if "None" is there in options.
shmsr
changed the title
| @@ -95,7 +95,7 @@ const D3_PERCENT_FORMAT_OPTIONS = [ | |||
| ['.3%', '.3% (12345.432 => 1234543.200%)'], | |||
| ]; | |||
|
|
|||
| const ROW_LIMIT_OPTIONS = [10, 50, 100, 250, 500, 1000, 5000, 10000, 50000]; | |||
| const ROW_LIMIT_OPTIONS = [-1, 10, 50, 100, 250, 500, 1000, 5000, 10000, 50000]; | |||
There was a problem hiding this comment.
As we are not adding handling of -1 in all widgets. we should not modify this array. Instead override options in visTypes.jsx. the possible way to do is as follow around Line 1422
controlOverrides: {
y_axis_format: {
label: t('Number format'),
},
row_limit: {
default: -1,
choices: formatSelectOptions([-1, ...ROW_LIMIT_OPTIONS]
}
}
... is js syntax to expand array in-place
CATEGORY
Choose one
SUMMARY
Add LIMIT selector in the control panel for BigChart and BigChartTotal charts.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TEST PLAN
ADDITIONAL INFORMATION
REVIEWERS