Fix: [MIQ-2130] Issues with publisher when value is 0 #268
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shmsr
changed the title
| @@ -54,7 +54,17 @@ const getFilter = (col, op, val) => { | |||
| } | |||
| } | |||
|
|
|||
| const valueToString = (value) => value ? value.toString() : value; | |||
| const valueToString = (value) => { | |||
arpit-agarwal
suggested changes
Nov 20, 2019
| @@ -54,7 +54,17 @@ const getFilter = (col, op, val) => { | |||
| } | |||
| } | |||
|
|
|||
| const valueToString = (value) => value ? value.toString() : value; | |||
| const valueToString = (value) => { | |||
| return value == null ? '' : (typeof value === 'object' && !value.toString ? '[object]' : String(value)); | |||
There was a problem hiding this comment.
Suggested change
| return value == null ? '' : (typeof value === 'object' && !value.toString ? '[object]' : String(value)); | |
| return value == null ? '' : (typeof value === 'object' && !value.toString ? '[TO_STRING_NOT_FOUND]' : String(value)); |
There was a problem hiding this comment.
I've done some error reporting. Plus, I've tested it and the results seem fine.
This function hits the error handling function when we have the below as parameter:
- null
- Object.create(null) /* Prototype less object */
There was a problem hiding this comment.
for null shouldn't this will be taken care by value == null
arpit-agarwal
suggested changes
Nov 20, 2019
| @@ -54,7 +54,22 @@ const getFilter = (col, op, val) => { | |||
| } | |||
| } | |||
|
|
|||
| const valueToString = (value) => value ? value.toString() : value; | |||
| const valueToStringErr = (value) => { | |||
| console.log("Error: [Prototype-less object]/ [null] encountered for getEffectiveExtraFilters"); | |||
There was a problem hiding this comment.
I am not sure syntax but there must be some way to use logger to log this at Info level
| } | ||
|
|
||
| const valueToString = (value) => { | ||
| return value == null ? valueToStringErr(value) : (typeof value === 'object' && !value.toString ? valueToStringErr(value) : String(value)); |
There was a problem hiding this comment.
I think for null we can return same as existing code i.e null
valueToString = (value) => value ? value.toString() : value;
arpit-agarwal
approved these changes
Nov 21, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CATEGORY
Choose one
SUMMARY
When '0' is published through a column, WHERE clause was dropped. Hence for 0, it wasn't working. For other numbers, it was working. After the fix, conversion to string is taken care of which fixes the error of not publishing when the value is 0.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TEST PLAN
ADDITIONAL INFORMATION
REVIEWERS