Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#[UIC-2139]: updated leaflet map id to dynamically created id #271

Merged
merged 1 commit into from
Jan 27, 2020
Merged

#[UIC-2139]: updated leaflet map id to dynamically created id #271

merged 1 commit into from
Jan 27, 2020

Conversation

rasmi-ranjan-guavus
Copy link

@rasmi-ranjan-guavus rasmi-ranjan-guavus commented Nov 14, 2019 •
edited
Loading

UIC-2139

CATEGORY

Choose one

  • Bug Fix
  • Enhancement (new features, refinement)
  • Refactor
  • Add tests
  • Build / Development Environment
  • Documentation

SUMMARY

updated leaflet map id to dynamically created id to visualize multiple maps in one dashboard

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TEST PLAN

ADDITIONAL INFORMATION

  • Has associated issue:
  • Changes UI
  • Requires DB Migration.
  • Confirm DB Migration upgrade and downgrade tested.
  • Introduces new feature or API
  • Removes existing feature or API

REVIEWERS

arpit-agarwal
arpit-agarwal approved these changes Nov 21, 2019
View reviewed changes
Copy link

@arpit-agarwal arpit-agarwal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

arpit-agarwal
arpit-agarwal approved these changes Jan 27, 2020
View reviewed changes
Copy link

@arpit-agarwal arpit-agarwal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@arpit-agarwal arpit-agarwal merged commit 59b7d38 into master Jan 27, 2020
@arpit-agarwal arpit-agarwal deleted the fix/UIC-2139-dynamic-id-leaflet branch January 27, 2020 07:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arpit-agarwal arpit-agarwal arpit-agarwal approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rasmi-ranjan-guavus @arpit-agarwal