Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#[UIC-2319]:Added support to pass on slice selections as filters to navigated dashboard #276

Merged
merged 1 commit into from
Jan 8, 2020

Conversation

jitendra-kumawat
Copy link

@jitendra-kumawat jitendra-kumawat commented Jan 8, 2020

CATEGORY

Choose one

  • Bug Fix
  • Enhancement (new features, refinement)
  • Refactor
  • Add tests
  • Build / Development Environment
  • Documentation

SUMMARY

Added support to pass on slice selections as filters to navigated dashboard

Workflow:-
1.All published selections of particular slice will be passed as filter to navigating dashboard
2.All passed on filters will be applied to all charts of navigated dashboard with in operator
3.These filters will be maintained till page is live in browser , not saved in slice metadata to restore.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TEST PLAN

ADDITIONAL INFORMATION

  • Has associated issue:
  • Changes UI
  • Requires DB Migration.
  • Confirm DB Migration upgrade and downgrade tested.
  • Introduces new feature or API
  • Removes existing feature or API

REVIEWERS

… to navigated dashboard

added support to pass on slice selections as filters to navigated dashboard

UIC-2319
Copy link

@ankursinghal2005 ankursinghal2005 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Good work

@ankursinghal2005 ankursinghal2005 merged commit 2504e91 into master Jan 8, 2020
@ankursinghal2005 ankursinghal2005 deleted the feat/UIC-952-preslice-filter branch January 8, 2020 10:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants