Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MIQ-2274: Add datasource info for published slices #277

Merged
merged 1 commit into from
Mar 9, 2020

Conversation

shmsr
Copy link

@shmsr shmsr commented Jan 23, 2020

When replicating dashboards with charts, the subscriber layer lists charts with duplicated names which makes harder for the user to link the publisher and subscriber correctly. While the motive of replication of dashboards is to use it with different datasources, so adding the datasource of the slices in the filter box selector would improve the experience of the administrator who's working the dashboards.

This commit adds datasource info appended with the slice's name in the subscriber layer's "Select chart" filter.

CATEGORY

Choose one

  • Bug Fix
  • Enhancement (new features, refinement)
  • Refactor
  • Add tests
  • Build / Development Environment
  • Documentation

SUMMARY

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TEST PLAN

  1. Duplicate dashboards along with the charts
  2. Go to the duplicated charts and change the data source
  3. Now go to the subscriber layer of the newly created charts
  4. Check if charts with same are differentiated on the basis of the data sources (Datasource is suffixed and enclosed in bracket)
  5. And test if publisher-subscriber is working

ADDITIONAL INFORMATION

  • Has associated issue:
  • Changes UI
  • Requires DB Migration.
  • Confirm DB Migration upgrade and downgrade tested.
  • Introduces new feature or API
  • Removes existing feature or API

REVIEWERS

When replicating dashboards with charts, the subscriber layer lists charts with duplicated names which makes harder for the user to link the publisher and subsciber correctly. While motive of replication of dashboards is to use it with different datasources, so adding the datasource of the slices in the filterbox selector would improve experience of the administrator who's working the dashboards.

This commit adds datasource info appended with the slice's name in the subscriber layer's "Select chart" filter.
Copy link

@arpit-agarwal arpit-agarwal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good work @subham-sarkar-guavus . .
Code looks good.

Copy link

@jitendra-kumawat jitendra-kumawat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jitendra-kumawat jitendra-kumawat merged commit da92293 into master Mar 9, 2020
@jitendra-kumawat jitendra-kumawat deleted the feature/subscriber-layer-datasource branch March 9, 2020 07:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants