Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(connector): support for S3 as datasource #280

Merged
merged 6 commits into from
Mar 9, 2020
Merged

feat(connector): support for S3 as datasource #280

merged 6 commits into from
Mar 9, 2020

Conversation

arpit-agarwal
Copy link

@arpit-agarwal arpit-agarwal commented Mar 4, 2020 •
edited
Loading

CATEGORY

Choose one

  • Bug Fix
  • Enhancement (new features, refinement)
  • Refactor
  • Add tests
  • Build / Development Environment
  • Documentation

SUMMARY

Connection string to fetch data from s3
https://superset.incubator.apache.org/installation.html#aws-athena
Use REST interface

awsathena+rest://{aws_access_key_id}:{aws_secret_access_key}@athena.{region_name}.amazonaws.com/{schema_name}?s3_staging_dir={s3_staging_dir}

Note: schema_name is database name

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TEST PLAN

ADDITIONAL INFORMATION

  • Has associated issue:
  • Changes UI
  • Requires DB Migration.
  • Confirm DB Migration upgrade and downgrade tested.
  • Introduces new feature or API
  • Removes existing feature or API

REVIEWERS

jitendra-kumawat
jitendra-kumawat approved these changes Mar 9, 2020
View reviewed changes
Copy link

@jitendra-kumawat jitendra-kumawat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jitendra-kumawat jitendra-kumawat merged commit b06b2b7 into master Mar 9, 2020
@jitendra-kumawat jitendra-kumawat deleted the feat/UIC-2432-s3-integration branch March 9, 2020 07:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jitendra-kumawat jitendra-kumawat jitendra-kumawat approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@arpit-agarwal @jitendra-kumawat