Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(dash-navigation): Configuration to enable/disable passing filter, when navigating to Dashboard B from Dashboard A . #281

Merged
merged 1 commit into from
Apr 15, 2020
Merged

feat(dash-navigation): Configuration to enable/disable passing filter, when navigating to Dashboard B from Dashboard A . #281

merged 1 commit into from
Apr 15, 2020

Conversation

avantika-karwasara
Copy link

@avantika-karwasara avantika-karwasara commented Apr 14, 2020 •
edited
Loading

UIC-2453

CATEGORY

Choose one

  • Bug Fix
  • Enhancement (new features, refinement)
  • Refactor
  • Add tests
  • Build / Development Environment
  • Documentation

SUMMARY

  • created checkbox component to paas filters to dashboard
  • for rest action use 'passFilters' property to pass filters
  • If property doesn't exist than filters won't paas; if property exist than will paas filters on the basis of value of checkbox

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

pass filter

TEST PLAN

ADDITIONAL INFORMATION

  • Has associated issue:
  • Changes UI
  • Requires DB Migration.
  • Confirm DB Migration upgrade and downgrade tested.
  • Introduces new feature or API
  • Removes existing feature or API

REVIEWERS

@avantika-karwasara avantika-karwasara changed the title Fix [UIC-2453]: When navigating to Dashboard B from Dashboard A . There should be configuration to enable/disable passing filter #[UIC-2453]: When navigating to Dashboard B from Dashboard A . There should be configuration to enable/disable passing filter Apr 14, 2020
@avantika-karwasara avantika-karwasara changed the title #[UIC-2453]: When navigating to Dashboard B from Dashboard A . There should be configuration to enable/disable passing filter feat(passing-filters): When navigating to Dashboard B from Dashboard A . There should be configuration to enable/disable passing filter Apr 15, 2020
@avantika-karwasara avantika-karwasara changed the title feat(passing-filters): When navigating to Dashboard B from Dashboard A . There should be configuration to enable/disable passing filter feat(passing-filters): Configuration to enable/disable passing filter, when navigating to Dashboard B from Dashboard A . Apr 15, 2020
jitendra-kumawat
jitendra-kumawat approved these changes Apr 15, 2020
View reviewed changes
Copy link

@jitendra-kumawat jitendra-kumawat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM and reviewed already against gitlab mr and this pr is part of migration of same merge_requests from gitlab to github repo.

@jitendra-kumawat jitendra-kumawat changed the title feat(passing-filters): Configuration to enable/disable passing filter, when navigating to Dashboard B from Dashboard A . feat(dash-navigation): Configuration to enable/disable passing filter, when navigating to Dashboard B from Dashboard A . Apr 15, 2020
@avantika-karwasara avantika-karwasara merged commit 60f4323 into master Apr 15, 2020
@avantika-karwasara avantika-karwasara deleted the fix/UIC-2453-github branch April 15, 2020 08:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jitendra-kumawat jitendra-kumawat jitendra-kumawat approved these changes

Assignees
No one assigned
Labels
#enhancement New feature or request #inner-source
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@avantika-karwasara @jitendra-kumawat