Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(CI):removed MarkupSafe as deps from pipfile and updated lock file #288

Merged
merged 1 commit into from
Apr 15, 2020

Conversation

jitendra-kumawat
Copy link

UIC-2505

CATEGORY

Choose one

  • Bug Fix
  • Enhancement (new features, refinement)
  • Refactor
  • Add tests
  • Build / Development Environment
  • Documentation

SUMMARY

Removed MarkupSafe as deps from pipfile and will it should be resolved internally with correct version as per master commit of (https://github.com/apache/incubator-superset/blob/master/setup.py)

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

NA

TEST PLAN

Validated over build setup

ADDITIONAL INFORMATION

  • Has associated issue:
  • Changes UI
  • Requires DB Migration.
  • Confirm DB Migration upgrade and downgrade tested.
  • Introduces new feature or API
  • Removes existing feature or API

REVIEWERS

@jitendra-kumawat jitendra-kumawat added the #bug Something isn't working label Apr 15, 2020
Copy link

@ankursinghal2005 ankursinghal2005 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jitendra-kumawat jitendra-kumawat merged commit 477bc07 into master Apr 15, 2020
@jitendra-kumawat jitendra-kumawat deleted the fix/UIC-2505-CI-build branch April 15, 2020 06:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
#bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants