Add version info based on commit hash. #16
Conversation
…slint setting auto-added[ch2336]
|
An approach on adding version to the api pieces. |
| @@ -13,6 +13,10 @@ import { express as voyagerMiddleware } from 'graphql-voyager/middleware'; | |||
| import apolloServer from './graphql'; | |||
| import expressLoggingOptions from './expressLogOptions'; | |||
|
|
|||
| const { version } = require('../package.json'); | |||
There was a problem hiding this comment.
interesting approach. while legit, is that really legit or are there some downstream node/npm circular issues? I honestly have no clue.
There was a problem hiding this comment.
None that I have run into in the past. package.json is just a file, and the goal is to have a single place for version info
| @@ -51,7 +51,9 @@ jobs: | |||
| with: | |||
| name: tc-api | |||
| - name: write .env file | |||
| run: echo ${{ secrets.ENV_FILE_PROD }} | base64 -d > tc-api/.env | |||
| run: | | |||
There was a problem hiding this comment.
check out https://github.com/lerna/lerna. this might be a package we can use to help with the version numbers. I see it used a lot across open source projects.
There was a problem hiding this comment.
Is your thought with lerna to put all the api's in one repo and configure as packages with lerna? That's a lot of change
| "peacock.lightForegroundColor": "#000" | ||
| "peacock.lightForegroundColor": "#000", | ||
| "editor.codeActionsOnSave": { | ||
| "source.fixAll.eslint": true |
There was a problem hiding this comment.
check this out.. microsoft/vscode#87096 mind you we already have formatOnSave, now I have no clue what we should be using.
There was a problem hiding this comment.
Yeah there was a message in vscode that said this is the . new place to do this. The old setting is underlined as deprecated.
brettski
deleted the
brettski/ch2336/add-release-information-to-sentry-io-when
branch
Sentry will tie to this. New eslint setting auto-added[ch2336]