Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds Carnemori, more flesh armor, and changes the Meathunk sprite #150

Merged
merged 9 commits into from
Jan 23, 2025

Conversation

Guloveos
Copy link
Collaborator

Description.
Adds the flesh god Carnemori
Adds a Malformed Carapace of flesh "A twisted armor made of flesh and bone, it's hard to tell where the armor ends and the wearer begins."
Changed the Meathunk sprite to be smaller and just over all better

🆑

  • add: Added Carnemori, and a new flesh armor
  • tweak: Tweaked the Meathunk sprite

@Creatorbot01
Copy link
Collaborator

Feel like carnemori shit something on build and debug.

@Erisfiregamer1
Copy link
Collaborator

Unhandled exception. System.AggregateException: One or more errors occurred. (One or more errors occurred. (CLIENT: 10.506s [ERRO] proto: Reading Robust.Shared.Prototypes.EntityPrototype(MobCarnemori) threw the following exception: System.ArgumentException: No data definition found for type System.Collections.Generic.List`1[Robust.Shared.GameObjects.PrototypeLayerData] with node type Robust.Shared.Serialization.Markdown.Mapping.MappingDataNode when reading

Blocked merge

@Erisfiregamer1
Copy link
Collaborator

Forcing a test rerun please wait

@Erisfiregamer1 Erisfiregamer1 marked this pull request as draft January 22, 2025 00:41
@Erisfiregamer1 Erisfiregamer1 marked this pull request as ready for review January 22, 2025 00:41
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

someone more familiar with mob code should give this a pass

@Creatorbot01
Copy link
Collaborator

think it still broken

Co-authored-by: TheDoctor1977 <[email protected]>
@TheDoctor1977 TheDoctor1977 added the Status: Awaiting Changes This PR needs its reviews addressed or changes to be made in order to be merged. label Jan 23, 2025
Copy link
Member

@TheDoctor1977 TheDoctor1977 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

test fails still related, please fix

@Guloveos
Copy link
Collaborator Author

I don't think any of the test fails relate to this PR anymore so I'm gonna merge this. I will work on all the build fails in another PR

@Guloveos Guloveos merged commit b3fabfd into The-Arcadis-Team:master Jan 23, 2025
10 of 13 checks passed
@Erisfiregamer1
Copy link
Collaborator

I don't think any of the test fails relate to this PR anymore so I'm gonna merge this. I will work on all the build fails in another PR

Test fails are in fact unrelated now and I'll put in some time solving them dw

@Guloveos
Copy link
Collaborator Author

I don't think any of the test fails relate to this PR anymore so I'm gonna merge this. I will work on all the build fails in another PR

Test fails are in fact unrelated now and I'll put in some time solving them dw

aye aye thanks for working on the test o7

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changes: Localization Changes: Sprite Changes: YML Status: Awaiting Changes This PR needs its reviews addressed or changes to be made in order to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants