Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use berkeley ABC in yosys build #141

Merged
merged 2 commits into from
Sep 3, 2021

Conversation

mathursanjiv
Copy link
Contributor

Fix for issue: https://openroad.atlassian.net/browse/OR-1094

Signed-off-by: Sanjiv Mathur [email protected]

Signed-off-by: Sanjiv Mathur <[email protected]>
@mathursanjiv mathursanjiv requested a review from maliberty August 30, 2021 18:00
@maliberty
Copy link
Member

This only updates the local build and not the docker build.

You should run secure-ci on this change.

@rovinski
Copy link
Collaborator

Seems weird that we're only updating ABC and not yosys?

@maliberty
Copy link
Member

Seems weird that we're only updating ABC and not yosys?
@rovinski yosys hasn't updated to the latest abc which we require.

@mathursanjiv
Copy link
Contributor Author

This only updates the local build and not the docker build.

You should run secure-ci on this change.

@maliberty Updated docker build. I cannot do secure CI run from public fork. Would do in a separate branch and share.

@maliberty
Copy link
Member

@maliberty Updated docker build. I cannot do secure CI run from public fork. Would do in a separate branch and share.

Approval pending on your result.

@mathursanjiv
Copy link
Contributor Author

@maliberty Updated docker build. I cannot do secure CI run from public fork. Would do in a separate branch and share.

Approval pending on your result.

Yes, have been having IT problems. Hopefully would get it resolved soon and fire runs.

Copy link
Member

@maliberty maliberty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

secure-ci passed

@mathursanjiv mathursanjiv merged commit affb7b4 into The-OpenROAD-Project:master Sep 3, 2021
@mathursanjiv mathursanjiv deleted the use_new_abc branch September 3, 2021 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants