Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sunxi-pwm: Fix broken PWM_SUNXI_ENHANCE driver #25

Closed

Conversation

chraac
Copy link

@chraac chraac commented Aug 29, 2024

Background

In PR armbian#6617, we've added the ethernet and pwm driver for zero2w for kernel version 6.6 and 6.7, now in 6.10, the pwm drvier interface have been changed that makes our driver failed to compile, here's a PR to fix that.

Changes:

  • Fix compiling error at the patch drivers-pwm-Add-pwm-sunxi-enhance-driver-for-h616.patch, adapt to new 6.10 pwm interface
  • Fix driver-allwinner-h618-emac.patch, now ethernet on zero2w works well
  • At sunxi64 edge config, enable CONFIG_PWM_SUNXI_ENHANCE as module

How Has This Been Tested?

  • Build and install to zero2w, the ethernet works well
    image

@chraac
Copy link
Author

chraac commented Aug 29, 2024

For the indentation issues, can have a commit to change the driver into tab ident

@chraac chraac marked this pull request as draft August 29, 2024 06:06
@The-going
Copy link
Owner

@chraac Good health!
Good job!

If you don't mind, can I clean up the history a bit?

@The-going
Copy link
Owner

For the indentation issues, can have a commit to change the driver into tab ident

You don't have to worry. I'll do it myself.

@chraac
Copy link
Author

chraac commented Aug 30, 2024

@chraac Good health! Good job!

If you don't mind, can I clean up the history a bit?

sure, gonna squash all the versions into one and clear the commit log.

@chraac chraac force-pushed the dev-fix-sunxi-eth-drv branch 2 times, most recently from 6cf034c to c0594a6 Compare August 30, 2024 03:49
@chraac chraac force-pushed the dev-fix-sunxi-eth-drv branch from 4dbc838 to be8aaf1 Compare August 30, 2024 03:55
@The-going
Copy link
Owner

@chraac Thank you very much.
I've taken all your changes and will add them after I fix mine, the ones that go before that.

@chraac chraac marked this pull request as ready for review August 31, 2024 01:24
@chraac chraac changed the title [WIP] sunxi-pwm: Fix broken PWM_SUNXI_ENHANCE driver sunxi-pwm: Fix broken PWM_SUNXI_ENHANCE driver Aug 31, 2024
@chraac
Copy link
Author

chraac commented Aug 31, 2024

@chraac Thank you very much. I've taken all your changes and will add them after I fix mine, the ones that go before that.

Cool! Do you mind merge this PR into your branch? Now I've squash all changes into one commit.

@The-going
Copy link
Owner

Now I've squash all changes into one commit.

@chraac PR is merged in cmdline.

@The-going The-going closed this Aug 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants