-
Notifications
You must be signed in to change notification settings - Fork 19.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improvements to Vampire Number #6110
Conversation
- Remove unused code - Just print formatted lines instead of accumulating them in a StringBuilder - Rename the method to reflect what it does - Make pseudo vampire number choice an argument
- Fix a bug in check for pseudo vampire number - Make method that split into digits accept vararg and slightly simplify it
…er to the beginning
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #6110 +/- ##
============================================
+ Coverage 73.65% 73.78% +0.13%
- Complexity 5114 5119 +5
============================================
Files 658 658
Lines 17649 17632 -17
Branches 3396 3391 -5
============================================
+ Hits 12999 13010 +11
+ Misses 4147 4118 -29
- Partials 503 504 +1 ☔ View full report in Codecov by Sentry. |
IMHO, limiting tests to just 3 static imports and forbidding to static import org.junit.jupiter.api.Assertions.* is too strict and actually hurts readability. Not gonna argue, just a thought. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thanks!
Several improvements to maths/VampireNumber code:
clang-format -i --style=file path/to/your/file.java