Enhancements to "Longest Increasing Subsequence" #209
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Performance improvement: Use
pushfirst!
directly when creating the resultlis_arr
instead of unnecessarily doingpush!
in a loop and thenreverse!
laterMore Julian code: Writing generic code is strongly encouraged in Julia, and it's more in line with Julian convention to accept an array of any
Integer
subtype, instead of artificially limiting it toInt
only. Sincewhere T <: Integer
is pretty intuitive and easy to make sense of, it doesn't particularly affect readability. And this makes it clearer which of the arrays used in the function are meant to hold values from the original array (those typedT
) and which are meant to hold indices (those typedInt
), which can make it easier to understand the algorithms.