Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Binary Length Improvements #212

Merged

Conversation

PraneethJain
Copy link
Contributor

@PraneethJain PraneethJain commented Oct 26, 2023

#207

  • Moved binary_length.jl from the string folder to the math folder.
  • Fix incorrect time complexity in the function documentation.
  • Added a faster implementation of bin_length.
  • Added tests for all the bin_length functions.

@codecov
Copy link

codecov bot commented Oct 26, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (ffd660b) 96.27% compared to head (a8ef3c4) 97.38%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #212      +/-   ##
==========================================
+ Coverage   96.27%   97.38%   +1.11%     
==========================================
  Files         137      137              
  Lines        1718     1721       +3     
==========================================
+ Hits         1654     1676      +22     
+ Misses         64       45      -19     
Files Coverage Δ
src/math/Math.jl 100.00% <ø> (ø)
src/math/binary_length.jl 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@uncomfyhalomacro uncomfyhalomacro merged commit e25f9c0 into TheAlgorithms:main Oct 29, 2023
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants