Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Project Euler 17-20 #219

Merged
merged 5 commits into from
Nov 13, 2023
Merged

Conversation

PraneethJain
Copy link
Contributor

Added solutions to Project Euler 17,18,19 and 20.

Copy link

codecov bot commented Nov 12, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (9e5a1b8) 97.41% compared to head (8e42bd1) 97.49%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #219      +/-   ##
==========================================
+ Coverage   97.41%   97.49%   +0.08%     
==========================================
  Files         138      142       +4     
  Lines        1738     1796      +58     
==========================================
+ Hits         1693     1751      +58     
  Misses         45       45              
Files Coverage Δ
src/project_euler/ProjectEuler.jl 100.00% <ø> (ø)
src/project_euler/problem_016.jl 100.00% <ø> (ø)
src/project_euler/problem_017.jl 100.00% <100.00%> (ø)
src/project_euler/problem_018.jl 100.00% <100.00%> (ø)
src/project_euler/problem_019.jl 100.00% <100.00%> (ø)
src/project_euler/problem_020.jl 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@uncomfyhalomacro
Copy link
Collaborator

well that's a lot, do you want me to merge this now?

@PraneethJain
Copy link
Contributor Author

Yeah, sure.

@PraneethJain
Copy link
Contributor Author

Would it be preferred to open separate PRs for each problem or bunching them together is fine?

@uncomfyhalomacro
Copy link
Collaborator

Would it be preferred to open separate PRs for each problem or bunching them together is fine?

It should be fine :D theyre all separate commits anyway. i will just do a merge commit with no squash

@uncomfyhalomacro uncomfyhalomacro merged commit fa5dd9c into TheAlgorithms:main Nov 13, 2023
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants