Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add wildcard pattern matching algorithm using FFT #12014

Closed
wants to merge 10 commits into from
Closed

Add wildcard pattern matching algorithm using FFT #12014

wants to merge 10 commits into from

Conversation

OnePunchMonk
Copy link

@OnePunchMonk OnePunchMonk commented Oct 12, 2024 •
edited
Loading

Description

This algorithm uses Fast Fourier Transform (FFT) to implement a wildcard pattern matching functionality. It efficiently finds occurrences of a given pattern, which may include wildcards, within a text string. The overall time complexity of the algorithm is O((n+m) log (n+m)), where n is the length of the text and m is the length of the pattern.

Change Summary

  • Added an algorithm for wildcard pattern matching using FFT.

Checklist

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms include at least one URL that points to Wikipedia or another similar explanation.
  • This pull request resolves issue number Wildcard pattern matching with FFT in O((n+m) log (n+m)) #11947.

References

For more information on Fast Fourier Transform and its applications, you can visit the following resources:

@algorithms-keeper algorithms-keeper bot added require descriptive names This PR needs descriptive function and/or variable names require tests Tests [doctest/unittest/pytest] are required require type hints https://docs.python.org/3/library/typing.html labels Oct 12, 2024
algorithms-keeper[bot]
algorithms-keeper bot reviewed Oct 12, 2024
View reviewed changes
Copy link

@algorithms-keeper algorithms-keeper bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Click here to look at the relevant links ⬇️

🔗 Relevant Links

Repository:

Python:

Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.
algorithms-keeper commands and options

algorithms-keeper actions can be triggered by commenting on this PR:

  • @algorithms-keeper review to trigger the checks for only added pull request files
  • @algorithms-keeper review-all to trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.

NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.

strings/wildcard_pattern_matching_fft.py Outdated Show resolved Hide resolved
strings/wildcard_pattern_matching_fft.py Outdated Show resolved Hide resolved
strings/wildcard_pattern_matching_fft.py Outdated Show resolved Hide resolved
@algorithms-keeper algorithms-keeper bot added the awaiting reviews This PR is ready to be reviewed label Oct 12, 2024
@algorithms-keeper algorithms-keeper bot added the tests are failing Do not merge until tests pass label Oct 12, 2024
@algorithms-keeper algorithms-keeper bot removed require descriptive names This PR needs descriptive function and/or variable names require tests Tests [doctest/unittest/pytest] are required require type hints https://docs.python.org/3/library/typing.html labels Oct 12, 2024
@algorithms-keeper algorithms-keeper bot added require descriptive names This PR needs descriptive function and/or variable names require tests Tests [doctest/unittest/pytest] are required labels Oct 12, 2024
algorithms-keeper[bot]
algorithms-keeper bot reviewed Oct 12, 2024
View reviewed changes
Copy link

@algorithms-keeper algorithms-keeper bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Click here to look at the relevant links ⬇️

🔗 Relevant Links

Repository:

Python:

Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.
algorithms-keeper commands and options

algorithms-keeper actions can be triggered by commenting on this PR:

  • @algorithms-keeper review to trigger the checks for only added pull request files
  • @algorithms-keeper review-all to trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.

NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.

strings/wildcard_pattern_matching_fft.py
from numpy.fft import fft, ifft


def preprocess_text_and_pattern(text: str, pattern: str) -> tuple[list[int], list[int]]:
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As there is no test file in this pull request nor any test function or class in the file strings/wildcard_pattern_matching_fft.py, please provide doctest for the function preprocess_text_and_pattern

strings/wildcard_pattern_matching_fft.py Outdated

return text_int, pattern_int

def fft_convolution(a: list[int], b: list[int]) -> np.ndarray:
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As there is no test file in this pull request nor any test function or class in the file strings/wildcard_pattern_matching_fft.py, please provide doctest for the function fft_convolution

Please provide descriptive name for the parameter: a

Please provide descriptive name for the parameter: b

strings/wildcard_pattern_matching_fft.py
return np.real(ifft(A * B))


def compute_a_fft(text_int: list[int], pattern_int: list[int]) -> np.ndarray:
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As there is no test file in this pull request nor any test function or class in the file strings/wildcard_pattern_matching_fft.py, please provide doctest for the function compute_a_fft

@OnePunchMonk OnePunchMonk force-pushed the add-wildcard-pattern-matching-fft branch from c276c58 to 9d6751c Compare October 12, 2024 16:43
@algorithms-keeper algorithms-keeper bot removed the require descriptive names This PR needs descriptive function and/or variable names label Oct 12, 2024
algorithms-keeper[bot]
algorithms-keeper bot reviewed Oct 12, 2024
View reviewed changes
Copy link

@algorithms-keeper algorithms-keeper bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Click here to look at the relevant links ⬇️

🔗 Relevant Links

Repository:

Python:

Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.
algorithms-keeper commands and options

algorithms-keeper actions can be triggered by commenting on this PR:

  • @algorithms-keeper review to trigger the checks for only added pull request files
  • @algorithms-keeper review-all to trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.

NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.

strings/wildcard_pattern_matching_fft.py
from numpy.fft import fft, ifft


def preprocess_text_and_pattern(text: str, pattern: str) -> tuple[list[int], list[int]]:
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As there is no test file in this pull request nor any test function or class in the file strings/wildcard_pattern_matching_fft.py, please provide doctest for the function preprocess_text_and_pattern

strings/wildcard_pattern_matching_fft.py

return text_int, pattern_int

def fft_convolution(first_seq: list[int], second_seq: list[int]) -> np.ndarray:
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As there is no test file in this pull request nor any test function or class in the file strings/wildcard_pattern_matching_fft.py, please provide doctest for the function fft_convolution

strings/wildcard_pattern_matching_fft.py



def compute_a_fft(text_int: list[int], pattern_int: list[int]) -> np.ndarray:
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As there is no test file in this pull request nor any test function or class in the file strings/wildcard_pattern_matching_fft.py, please provide doctest for the function compute_a_fft

@OnePunchMonk OnePunchMonk force-pushed the add-wildcard-pattern-matching-fft branch from cfa099f to f4efe93 Compare October 12, 2024 16:46
algorithms-keeper[bot]
algorithms-keeper bot reviewed Oct 12, 2024
View reviewed changes
Copy link

@algorithms-keeper algorithms-keeper bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Click here to look at the relevant links ⬇️

🔗 Relevant Links

Repository:

Python:

Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.
algorithms-keeper commands and options

algorithms-keeper actions can be triggered by commenting on this PR:

  • @algorithms-keeper review to trigger the checks for only added pull request files
  • @algorithms-keeper review-all to trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.

NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.

strings/wildcard_pattern_matching_fft.py
from numpy.fft import fft, ifft


def preprocess_text_and_pattern(text: str, pattern: str) -> tuple[list[int], list[int]]:
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As there is no test file in this pull request nor any test function or class in the file strings/wildcard_pattern_matching_fft.py, please provide doctest for the function preprocess_text_and_pattern

strings/wildcard_pattern_matching_fft.py

return text_int, pattern_int

def fft_convolution(first_seq: list[int], second_seq: list[int]) -> np.ndarray:
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As there is no test file in this pull request nor any test function or class in the file strings/wildcard_pattern_matching_fft.py, please provide doctest for the function fft_convolution

strings/wildcard_pattern_matching_fft.py



def compute_a_fft(text_int: list[int], pattern_int: list[int]) -> np.ndarray:
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As there is no test file in this pull request nor any test function or class in the file strings/wildcard_pattern_matching_fft.py, please provide doctest for the function compute_a_fft

@algorithms-keeper algorithms-keeper bot removed the tests are failing Do not merge until tests pass label Oct 12, 2024
@cclauss
Copy link
Member

cclauss commented Nov 1, 2024

Closing require_tests PRs to prepare for Hacktoberfest

@cclauss cclauss closed this Nov 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@algorithms-keeper algorithms-keeper[bot] algorithms-keeper[bot] left review comments

Assignees
No one assigned
Labels
awaiting reviews This PR is ready to be reviewed require tests Tests [doctest/unittest/pytest] are required
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@OnePunchMonk @cclauss