Fixes on the code style based on the Code review and flake8. #12389
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
And Refactored quick_sort method to improve code readability
for more information, see https://pre-commit.ci
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi TheAlgorithms Team,
I hope this message finds you well. My name is Wadie Botros, and I am currently working on an assignment for a course at Potsdam University, Germany. As part of the assignment, I reviewed and refactored the quick_sort.py file in your repository to improve its readability and maintainability.
Changes Made:
Extracted Partition Logic:
Moved the partitioning logic into a separate partition function to improve readability and maintainability.
Improved Naming Conventions:
Renamed variables for better clarity (lesser to lesser_partition and greater to greater_partition).
Separated User Input Logic:
Created a get_user_input function to handle user input separately from the sorting logic.
I believe these changes will make the code easier to maintain and understand for future contributors. If you have any questions or need further modifications, please feel free to discuss them with me. I am happy to make any adjustments as needed.
Thank you for considering my contribution. I look forward to your feedback.
Best regards,
Wadie Botros