Add doctests for graphs_floyd_warshall.py #12436
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
algorithms-keeper
bot
added
enhancement
for more information, see https://pre-commit.ci
algorithms-keeper
bot
added
tests are failing
for more information, see https://pre-commit.ci
algorithms-keeper
bot
added
tests are failing
|
Added doc tests, contributes to resolving the issue #9943 |
|
@poyea Hi. I just added some tests to improve the coverage. Could you check it pls? Thank you |
|
@cclauss Hi. I added some tests to improve the coverage. Could you please check it? Thank you. |
cclauss
reviewed
Dec 18, 2024
cclauss
reviewed
Dec 18, 2024
Co-authored-by: Christian Clauss <[email protected]>
for more information, see https://pre-commit.ci
algorithms-keeper
bot
added
tests are failing
tianyizheng02
requested changes
Dec 30, 2024
Comment on lines
+9
to
+16
| # 1. For all edges from v to n, distance[i][j] = weight(edge(i, j)). | ||
|
|
||
| # 2. distance[i][j] = min(distance[i][j], distance[i][k] + distance[k][j]). | ||
|
|
||
| # 3. Step 2 is true for each pair of vertices.Repeat for k vertex in the graph. | ||
|
|
||
| # 4. Whenever distance[i][j] is given a new minimum value, | ||
| # next vertex[i][j] = next vertex[i][k]. |
There was a problem hiding this comment.
This algorithm explanation should be moved into the docstring at the top of the file
|
|
||
| _print_dist(dist, v) | ||
| return dist, v | ||
| return dist, vertex |
There was a problem hiding this comment.
Is vertex just the input parameter vertex? If this variable isn't being modified in the function, then there's no need to return it again because we already know what the value is.
| @@ -1,62 +1,112 @@ | |||
| # floyd_warshall.py | |||
There was a problem hiding this comment.
Suggested change
| # floyd_warshall.py |
I'm not sure why this comment is here
tianyizheng02
added
awaiting changes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your change:
Contributes to #9943
Added Doc tests
Added algorithm
Added type hints
Modified the function to return result
Checklist: