Update data_structures/arrays/median_two_array.py #12455
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for more information, see https://pre-commit.ci
15 tasks
cclauss
reviewed
Dec 29, 2024
| nums1: The first array. | ||
| nums2: The second array. | ||
| nums1: The first sorted array. | ||
| nums2: The second sorted array. |
There was a problem hiding this comment.
We need this function to fail if either array is not sorted and we need one or more tests that prove it does so.
cclauss
reviewed
Dec 29, 2024
|
|
||
| if total % 2 == 1: # If the total number of elements is odd | ||
| return float(merged[total // 2]) # then return the middle element | ||
| # Insert 2: Debugging: Log partition indices and elements (useful for large arrays) |
There was a problem hiding this comment.
Suggested change
| # Insert 2: Debugging: Log partition indices and elements (useful for large arrays) | |
| # Insert 2: Debugging: Log partition indices and elements (useful for large | |
| # arrays) |
cclauss
reviewed
Dec 29, 2024
| low = partition1 + 1 | ||
|
|
||
| # Insert 3: Remove redundant exception, already handled at the beginning | ||
| # raise ValueError("Input arrays are not sorted.") # This line is no longer necessary. |
There was a problem hiding this comment.
As long as there is a test that proves that failure then we can consider to remove this.
cclauss
reviewed
Dec 29, 2024
|
|
||
| Returns: | ||
| True if the array is sorted, False otherwise. | ||
| """ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your change:
Checklist: