Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix UI tooltips #1144

Merged
merged 1 commit into from
Aug 14, 2024
Merged

Fix UI tooltips #1144

merged 1 commit into from
Aug 14, 2024

Conversation

psykana
Copy link
Contributor

@psykana psykana commented Aug 14, 2024

Radio button, checkbox, slider gadgets set their tooltips here:

if (tooltip_window->m_tooltip != nullptr) {
tooltip_window->m_tooltip(tooltip_window, &tooltip_window->m_instData, packed_mouse_coords);
} else if (tooltip_window->m_instData.Get_Tooltip_Text_Length() != 0) {
g_theMouse->Set_Cursor_Tooltip(
tooltip_window->m_instData.Get_Tooltip_Text(), tooltip_window->m_instData.m_tooltipDelay, 0, 1.0f);
}

Since GameWindow ctor incorrectly initialized window->m_tooltip to a stub function, Thyme never got past the first check.

That didn't fix comboboxes though, which led me to GameWindowManager::Is_Hidden().

Fixes #1138
Fixes #998

Copy link
Contributor

@xezon xezon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes in GameWindowManager::Is_Hidden look logical to me. Change in constructor I do not know.

@jonwil
Copy link
Contributor

jonwil commented Aug 14, 2024

Changes in GameWindowManager::Is_Hidden are correct.

Copy link
Contributor

@jonwil jonwil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, approved.

@xezon xezon merged commit ba7056b into TheAssemblyArmada:develop Aug 14, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Some UI tooltips don't appear Tool tip strings for map starting positions do not show in menu
3 participants