Fix game pools with __SANITIZE_ADDRESS__ #1161
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
feliwir
force-pushed
the
fix-memory-allocators-for-asan
branch
from
aa94a82 to
b89cf74
Compare
feliwir
reviewed
Sep 19, 2024
| @@ -139,7 +143,9 @@ void MemoryPool::Free_Block(void *block) | |||
| if (block == nullptr) { | |||
| return; | |||
| } | |||
|
|
|||
| #ifdef __SANITIZE_ADDRESS__ | |||
| free(block); | |||
There was a problem hiding this comment.
I think we should return afterwards? otherwise it will try deleting it otherwise / applying "delete"
There was a problem hiding this comment.
Where is that delete? I do not see that.
xezon
commented
Sep 19, 2024
| @@ -94,8 +94,6 @@ void Init_Memory_Manager() | |||
| captainslog_dbgassert(g_thePreMainInitFlag, "memory manager is already inited"); | |||
| } | |||
|
|
|||
| #if defined GAME_DEBUG && !defined __SANITIZE_ADDRESS__ | |||
feliwir
approved these changes
Sep 20, 2024
Suardi1985
approved these changes
Sep 25, 2024
Suardi1985
approved these changes
Sep 25, 2024
Suardi1985
approved these changes
Sep 25, 2024
Suardi1985
approved these changes
Sep 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change fixes game pools with
__SANITIZE_ADDRESS__.Before, textures would just render black in w3dview tool. Unclear why exactly, but this change reinstates game pools and replaces the pool allocator with
mallocandfree.Textures render normally now.