Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bevy_lint::driver::main() should not return Result<(), ()> #17

Closed
BD103 opened this issue Aug 30, 2024 · 0 comments · Fixed by #23
Closed

bevy_lint::driver::main() should not return Result<(), ()> #17

BD103 opened this issue Aug 30, 2024 · 0 comments · Fixed by #23
Assignees
Labels
A-Linter Related to the linter and custom lints C-Code-Quality An improvement of readability or quality

Comments

@BD103
Copy link
Member

BD103 commented Aug 30, 2024

pub fn main() -> Result<(), ()> {

I want this function to have the majority of control over the program, but a Result<(), ()> seems silly. (And Clippy is complaining about it, too!) I'm thinking it should be replaced with an ExitCode instead.

@BD103 BD103 added A-Linter Related to the linter and custom lints C-Code-Quality An improvement of readability or quality labels Aug 30, 2024
@BD103 BD103 self-assigned this Aug 30, 2024
@BD103 BD103 closed this as completed in #23 Aug 30, 2024
@BD103 BD103 closed this as completed in 46d0555 Aug 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Linter Related to the linter and custom lints C-Code-Quality An improvement of readability or quality
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant