Skip to content

Commit

Permalink
Cherry-picking pull request #5 (ed2850a) and ab74a36
Browse files Browse the repository at this point in the history
💥 enforce minimum shadow version _1.2.3_.

This library depends on the first compatible shadow version. The
developer can enforce newer versions by just depending on them. This
fix avoids to possibly break old builds and keeps included shadow
version without the need to `force` it.
  • Loading branch information
TheBoegl committed Jan 20, 2018
1 parent 097c043 commit 9281c73
Show file tree
Hide file tree
Showing 2 changed files with 10 additions and 4 deletions.
12 changes: 9 additions & 3 deletions build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -29,13 +29,19 @@ repositories {
group 'de.sebastianboegl.gradle.plugins'

// no real semantic versioning (the MAJOR version number correspond to the MAJOR shadow plugin version number)
version "${shadowVersion}.0.1"
version "${majorShadowVersion}.0.1"

def shadowVersions = [
'1': '1.2.3',
'2': '2.0.0'
]
def shadowVersion = shadowVersions[majorShadowVersion]

dependencies {
compile gradleApi()
compile localGroovy()
compile(group: 'org.apache.logging.log4j', name: 'log4j-core', version: '2.+')
compile "com.github.jengelman.gradle.plugins:shadow:${shadowVersion}.+"
compile(group: 'org.apache.logging.log4j', name: 'log4j-core', version: '2.10.0')
compile "com.github.jengelman.gradle.plugins:shadow:${shadowVersion}"

testCompile gradleTestKit()
testCompile ('org.spockframework:spock-core:1.0-groovy-2.4') {
Expand Down
2 changes: 1 addition & 1 deletion gradle.properties
Original file line number Diff line number Diff line change
@@ -1 +1 @@
shadowVersion = 1
majorShadowVersion = 1

0 comments on commit 9281c73

Please sign in to comment.