Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conor develop 20240503 update #916

Merged
merged 5 commits into from
Jun 6, 2024

Conversation

AdvancedImagingUTSW
Copy link
Collaborator

No description provided.

conorhughmcfadden and others added 5 commits May 3, 2024 19:10
- Added TonyWilson import to feature_related_functions
- More strict stopping condition in adaptive_optics, otherwise would not continues onto z-stack
TonyWilson is not __init__ for every multiposition... so some variables need to be reinitialized elsewhere, otherwise they are re-used
Added the LUDL and NI filter wheels to the documentation. The NI filter wheel is currently pending until @SJShep merges his PR (some further communication necessary).

Configuration database updated.
Copy link

codecov bot commented Jun 6, 2024

Codecov Report

Attention: Patch coverage is 5.88235% with 48 lines in your changes missing coverage. Please review.

Project coverage is 51.43%. Comparing base (072e9bc) to head (e1cb80e).

Files Patch % Lines
...te/model/devices/filter_wheel/filter_wheel_ludl.py 0.00% 33 Missing ⚠️
src/navigate/model/features/adaptive_optics.py 0.00% 11 Missing ⚠️
src/navigate/model/device_startup_functions.py 33.33% 4 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #916      +/-   ##
===========================================
- Coverage    51.49%   51.43%   -0.07%     
===========================================
  Files          178      179       +1     
  Lines        19072    19108      +36     
===========================================
+ Hits          9822     9828       +6     
- Misses        9250     9280      +30     
Flag Coverage Δ
unittests 51.43% <5.88%> (-0.07%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@AdvancedImagingUTSW AdvancedImagingUTSW requested review from conorhughmcfadden and removed request for conorhughmcfadden June 6, 2024 15:24
@AdvancedImagingUTSW AdvancedImagingUTSW merged commit f77ffba into develop Jun 6, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants