Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add stage offset in the MoveToNextPositionInMultiPositionTable feature #949

Conversation

annie-xd-wang
Copy link
Collaborator

No description provided.

@AdvancedImagingUTSW
Copy link
Collaborator

Background: The software provides for an offset to be applied when switching between different microscopes. For Jinlong's system, you could find a feature in the low-res side, then switch the microscope, and the coordinates from the configuration.yaml file would be pulled and applied to the stages:

      x_offset: 0
      y_offset: 0
      z_offset: 0
      f_offset: 0
      theta_offset: 0

However, this correction was only applied once (e.g., to your current stage position). If features were added to the multi-position table in one mode, and then you switched to the other mode, the offset would not have been applied to the multi-position table. Now, the multi-position table logs which mode the positions were added in, and any subsequent move in a different mode will apply the offset provided in the configuration file.

@AdvancedImagingUTSW AdvancedImagingUTSW self-requested a review July 24, 2024 22:00
@AdvancedImagingUTSW
Copy link
Collaborator

Tested by @JinlongL. Some unit tests would be valuable in the future, and we need to document how to properly use these features.

@AdvancedImagingUTSW AdvancedImagingUTSW merged commit 315f667 into TheDeanLab:develop Jul 24, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants