Update camera_view.py #986
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #986 +/- ##
========================================
Coverage 53.90% 53.91%
========================================
Files 178 178
Lines 19521 19555 +34
========================================
+ Hits 10523 10543 +20
- Misses 8998 9012 +14
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
annie-xd-wang
previously approved these changes
Sep 13, 2024
…gate into offset-crosshair
I want the location of the crosshair to stay between acquisitions, at least until someone clicks reset display...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm not 100% sure if the math is performed correctly since it is complicated by the fact that the crosshair is added to the zoom image. But my interpretation is that if the user wants to put the crosshair at position (128, 128) for a 512 x 512 image, then it should stay there when they zoom in.